use refactored find a pat script to pass token to slash command dispatch action via env #16321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzztimbo
changed the title
supertopher
approved these changes
Sep 6, 2022
| - name: Slash Command Dispatch | ||
| id: scd | ||
| uses: peter-evans/slash-command-dispatch@v2 | ||
| with: | ||
| token: ${{ secrets.SUPERTOPHER_PAT }} | ||
| token: ${{ env.PAT }} |
There was a problem hiding this comment.
There was a problem hiding this comment.
Nope. Github recognizes the PAT as a secret, but probably not other strings?
c-p-b
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
LGTM, but with the concern raised of token reusage tracked in https://github.com/airbytehq/airbyte-cloud/issues/2641
git-phu
approved these changes
Sep 6, 2022
zzztimbo
deleted the
tim/use-env-to-pass-pat-to-slash-command-dispatcher
branch
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reinstates the work of @tuliren's PR by using a refactored
find_non_rate_limited_PATthat writes the token to env (not base64 encoded).Tests