-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use refactored find a pat script to pass token to slash command dispatch action via env #16321
use refactored find a pat script to pass token to slash command dispatch action via env #16321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Slash Command Dispatch | ||
id: scd | ||
uses: peter-evans/slash-command-dispatch@v2 | ||
with: | ||
token: ${{ secrets.SUPERTOPHER_PAT }} | ||
token: ${{ env.PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but with the concern raised of token reusage tracked in https://github.com/airbytehq/airbyte-cloud/issues/2641
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
also appreciate the links to the test runs!
Summary
This reinstates the work of @tuliren's PR by using a refactored
find_non_rate_limited_PAT
that writes the token to env (not base64 encoded).Tests