Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source-AlloyDB for Postgres: added new connector #16323

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Sep 4, 2022

What

Google recently introduced a new DB "AlloyDB for PostgreSQL".
A fully managed PostgreSQL-compatible database service for your most demanding enterprise database workloads. AlloyDB combines the best of Google with one of the most popular open-source database engines, PostgreSQL, for superior performance, scale, and availability.

We want to have a dedicated connector for it in our connector list.

How

Added a new connector.

Tested locally on AlloyDB instance
Selection_455
Selection_456
Selection_457

🚨 User Impact 🚨

No breaking changes, this is a new connector.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 4, 2022
@etsybaev etsybaev linked an issue Sep 4, 2022 that may be closed by this pull request
@etsybaev etsybaev temporarily deployed to more-secrets September 4, 2022 16:04 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 4, 2022 16:28 Inactive
@etsybaev etsybaev changed the title [16174] Source-AlloyDB for Postgres: added new connector 🎉Source-AlloyDB for Postgres: added new connector Sep 4, 2022
@etsybaev etsybaev temporarily deployed to more-secrets September 4, 2022 16:34 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 5, 2022 15:37 Inactive
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review September 5, 2022 16:37
Copy link
Contributor

@grishick grishick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't forget to publish before mergin.

@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 7, 2022

/test connector=connectors/source-alloydb

🕑 connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3005652670
✅ connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/3005652670
No Python unittests run

Build Passed

Test summary info:

All Passed

@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 7, 2022

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/3005709964


Connector Did it publish? Were definitions generated?
connectors/source-alloydb

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@etsybaev etsybaev merged commit 63deca2 into master Sep 7, 2022
@etsybaev etsybaev deleted the etsybaiev/source-alloydb-16174-add-new-connector branch September 7, 2022 08:41
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* [16174] Source-AlloyDB for Postgres: added new connector
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* [16174] Source-AlloyDB for Postgres: added new connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/alloydb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an AlloyDB branded version of Postgres Source connector
4 participants