🪟 🔧 Add experiment information to page views events (Segment) #16329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
approved these changes
Sep 5, 2022
krishnaglick
reviewed
Sep 6, 2022
| @@ -7,7 +7,7 @@ export class AnalyticsService { | |||
|
|
|||
| alias = (newId: string): void => this.getSegmentAnalytics()?.alias?.(newId); | |||
|
|
|||
| page = (name: string): void => this.getSegmentAnalytics()?.page?.(name); | |||
| page = (name: string): void => this.getSegmentAnalytics()?.page?.(name, { ...this.context }); | |||
There was a problem hiding this comment.
Nit as I was out Monday: We don't need to object spread.
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We need to know what experiment the user is on when viewing different pages
How
Thanks to a prior implementation, we were already adding experiments information to the context. The only thing we needed to do was adding that piece of context to
analytics.page()🚨 User Impact 🚨
None