-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dbt-clickhouse version from 1.1.7 to 1.1.8 #16339
Conversation
airbyte-integrations/bases/base-normalization/clickhouse.Dockerfile
Outdated
Show resolved
Hide resolved
/test connector=bases/base-normalization
Build FailedTest summary info:
|
some errors from pip because of old and unsupported dbt image( |
I don't feel comfortable changing the base image. Can we try to install the clickhouse lib without forcing the dbt-core version? |
Done. You can re-run the workflow, but i'm not too sure anything'll change |
/test connector=bases/base-normalization
Build PassedTest summary info:
|
/test connector=connectors/destination-clickhouse
Build PassedTest summary info:
|
Resolved the conflict, version bumped again. @marcosmarxm @grishick |
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Looks like publish command timed out. Not sure why it took more than 4 hours though |
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
I'll try again. |
…bytehq#16339) * Bump dbt-clickhouse version from 1.1.7 to 1.1.8 * pin dbt<1.2 * update doc * pin dbt core lt 1.2 * bump normalization version * loosen requirements * fix md * remove empty line * bump normalization version in worker * bump normalization version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
…bytehq#16339) * Bump dbt-clickhouse version from 1.1.7 to 1.1.8 * pin dbt<1.2 * update doc * pin dbt core lt 1.2 * bump normalization version * loosen requirements * fix md * remove empty line * bump normalization version in worker * bump normalization version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
What
When working with complex DBT projects, sometimes Cronjobs,Builds, and Airbyte jobs interfere with each other, and cause SELECT errors or deadlocks when tables are being recreated by one or several processes. This was addressed in dbt-clickhouse PR, updating dbt-clickhouse version in combination with ClickHouse Atomic engine and SYNC setting should help avoid those issues since normalization and table renames are performed by Airbyte with dbt-clickhouse.
How
Bump dbt-clickhouse version from 1.1.7 to 1.1.8
dbt-core is pinned at 1.1.2 with 1.2.x update pending in the coming weeks
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.