🪟 🎨 🧹 Migrate Input and TextArea to SCSS
#16378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
changed the title
Input and TextArea to SCSS Input and TextArea to SCSS
edmundito
force-pushed
the
edmundito/cleanup-input-components
branch
from
f7a98d5
to
55e3a63
Compare
krishnaglick
reviewed
Sep 7, 2022
| {isVisibilityButtonVisible ? ( | ||
| <VisibilityButton | ||
| <Button |
There was a problem hiding this comment.
Replacing button looks like it's going to be fun
airbyte-webapp/src/components/base/TextArea/TextArea.module.scss
Outdated
Show resolved
Hide resolved
krishnaglick
approved these changes
Sep 8, 2022
|
@krishnaglick the design of these two needs to be revisited so that they're consistent and match Figma. For now, the goal was to do a bit of cleanup. |
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Migrate TextArea component to SCSS and add Storybook * Move Input styles to SCSS, add Storybook * Fix Input stylelint issues * Fix hover selector on Input container to avoid hovering on focus * Fix Input focus test by using style file * Add missing & to Textarea style * Fix styleint inssue in Input * Move input testid before props
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Migrate TextArea component to SCSS and add Storybook * Move Input styles to SCSS, add Storybook * Fix Input stylelint issues * Fix hover selector on Input container to avoid hovering on focus * Fix Input focus test by using style file * Add missing & to Textarea style * Fix styleint inssue in Input * Move input testid before props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to #15791
Migrates
InputandTextAreato SCSS and adds Storybook. The styles are kept as they were before exactly instead of applying any updates that my mismatch the current Figma design (this may be done as a separate PR in the future.)How
Recommended reading order
Top to bottom
Tests