Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-instagram: fix incompatible metrics error for reels. #16428

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Sep 8, 2022

What

Closes #14524

How

  • Reels have a VIDEO media_type but its metrics are different from the video metrics we defined.
  • According to the API documentation , the following metrics are compatible for reels:
    ["comments", "likes", "plays", "reach", "saved", "shares", "total_interactions"]
  • To know if an IGMedia is a REELS we need to retrieve the media_product_type attribute on IGMedia items.

@alafanechere alafanechere marked this pull request as ready for review September 8, 2022 10:57
@alafanechere
Copy link
Contributor Author

alafanechere commented Sep 8, 2022

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3014518337
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3014518337
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        38     11    71%
source_instagram/streams.py      210     92    56%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            345    130    62%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/source.py        38      1    97%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      210     24    89%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            345     35    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 26 passed, 1 skipped in 327.05s (0:05:27) ===================

@alafanechere alafanechere changed the title Source-instagram: fix incompatible metrics error for reel. Source-instagram: fix incompatible metrics error for reels. Sep 8, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 8, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented Sep 8, 2022

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/3015486977


Connector Did it publish? Were definitions generated?
connectors/source-instagram

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere merged commit 7831339 into master Sep 8, 2022
@alafanechere alafanechere deleted the augustin/source-instagram/fix-incompatible-metrics-for-reel branch September 8, 2022 14:09
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@pflajszer
Copy link

pflajszer commented Oct 18, 2022

hello, there's also a workaround, but it's a bit hacky, so only if you're forced to/short on resource...

if (post.Permalink.Contains("reel"))
{
    // the post is of reel type...
}

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Instagram: Exception: Incompatible metric for reels
5 participants