Fix intercom #16540
Merged
Fix intercom #16540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinchia
approved these changes
Sep 9, 2022
sherifnada
reviewed
Sep 9, 2022
There was a problem hiding this comment.
@benmoriceau i would recommend removing the anyOf entirely and just making the object definition:
"tags": {
"type": "array",
"items": {
"type": ["null", "object"],
"properties": {
"type": {
"type": "string"
},
"name": {
"type": "string"
},
"id": {
"type": "integer"
}
}
}
}
}
same for the object below
Done |
|
/test connector=connectors/soruce-intercom
Build FailedTest summary info: |
|
/test connector=connectors/source-intercom
Build FailedTest summary info: |
|
/test connector=connectors/source-intercom
Build PassedTest summary info: |
|
@benmoriceau I don't see it on the branch - do you need to git push? |
|
@sherifnada, Yeah, I forget to push, It is updated now but I am having issue to test. It seem that the bmusko plugin version got updated today. |
|
/test connector=connectors/source-intercom
Build PassedTest summary info: |
|
/test connector=connectors/source-intercom
Build PassedTest summary info: |
|
/publish connector=connectors/source-intercom
if you have connectors that successfully published but failed definition generation, follow step 4 here |
github-actions
bot
added
the
area/documentation
|
/publish connector=connectors/source-intercom
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
With the source intercom version 0.1.26, it stucks when refreshing the source schema, and I found some error logs in the server pod that seems related to this change @benmoriceau |
|
Hello @nauxliu, |
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Fix intercom * PR comments * test * Restore bmusko version * Bump version and update changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Fix intercom * PR comments * test * Restore bmusko version * Bump version and update changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the intercom schema, related to https://github.com/airbytehq/oncall/issues/463
The check which is performed to see if a property/array is a oneOf/allOf/anyOf is based on the presence of the
typefield.Because the type were specified if the oneOf is contains in an array, the array was not considered as containing a oneOf and thus was not excluded from the diff comparison which is expected.