-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intercom #16540
Fix intercom #16540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benmoriceau i would recommend removing the anyOf
entirely and just making the object definition:
"tags": {
"type": "array",
"items": {
"type": ["null", "object"],
"properties": {
"type": {
"type": "string"
},
"name": {
"type": "string"
},
"id": {
"type": "integer"
}
}
}
}
}
same for the object below
Done |
/test connector=connectors/soruce-intercom
Build FailedTest summary info:
|
/test connector=connectors/source-intercom
Build FailedTest summary info:
|
/test connector=connectors/source-intercom
Build PassedTest summary info:
|
@benmoriceau I don't see it on the branch - do you need to git push? |
@sherifnada, Yeah, I forget to push, It is updated now but I am having issue to test. It seem that the bmusko plugin version got updated today. |
/test connector=connectors/source-intercom
Build PassedTest summary info:
|
/test connector=connectors/source-intercom
Build PassedTest summary info:
|
/publish connector=connectors/source-intercom
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-intercom
if you have connectors that successfully published but failed definition generation, follow step 4 here |
With the source intercom version 0.1.26, it stucks when refreshing the source schema, and I found some error logs in the server pod that seems related to this change @benmoriceau
|
Hello @nauxliu, |
* Fix intercom * PR comments * test * Restore bmusko version * Bump version and update changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Fix intercom * PR comments * test * Restore bmusko version * Bump version and update changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Fix the intercom schema, related to https://github.com/airbytehq/oncall/issues/463
The check which is performed to see if a property/array is a oneOf/allOf/anyOf is based on the presence of the
type
field.Because the type were specified if the oneOf is contains in an array, the array was not considered as containing a oneOf and thus was not excluded from the diff comparison which is expected.