Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish base-normalization #16545

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Publish base-normalization #16545

merged 3 commits into from
Sep 9, 2022

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Sep 9, 2022

What

I missed doing the / publish command on the original PR.
This PR was created in order to publish.

@rodireich rodireich linked an issue Sep 9, 2022 that may be closed by this pull request
@rodireich
Copy link
Contributor Author

rodireich commented Sep 9, 2022

/publish connector=bases/base-normalization

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/3024425539


Connector Did it publish? Were definitions generated?
bases/base-normalization

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@rodireich rodireich changed the title dummy Publish base-normalization Sep 9, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 9, 2022
@rodireich rodireich requested a review from edgao September 9, 2022 21:56
@rodireich rodireich marked this pull request as ready for review September 9, 2022 21:56
@rodireich rodireich requested a review from a team as a code owner September 9, 2022 21:56
@@ -24,7 +24,6 @@
import org.junit.jupiter.params.provider.ValueSource;

class SshTunnelTest {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this pass SUB_BUILD=CONNECTORS_BASE ./gradlew format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does

@rodireich rodireich merged commit 43b8d8b into master Sep 9, 2022
@rodireich rodireich deleted the 7198-publish-normalization branch September 9, 2022 22:10
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Tunnel: allow using OPENSSH key format
2 participants