Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes case where there is nothing to kill #16661

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Fixes case where there is nothing to kill #16661

merged 2 commits into from
Sep 13, 2022

Conversation

supertopher
Copy link
Contributor

fixes an edgewise where the zombie killer couldn't find something to kill.

broken run example:

https://github.com/airbytehq/airbyte/actions/runs/3046185508/jobs/4911196526

output from local test with 0 things to kill

# early text omitted because TOKEN
/tools/bin/gh_action_zombie_killer:22: org=airbytehq
./tools/bin/gh_action_zombie_killer:24: repo_list='airbyte airbyte-cloud'
./tools/bin/gh_action_zombie_killer:27: for repo in '$repo_list'
./tools/bin/gh_action_zombie_killer:29: runner_for_page_count=1
./tools/bin/gh_action_zombie_killer:30: page_count=0
./tools/bin/gh_action_zombie_killer:31: all_runner_ids=
./tools/bin/gh_action_zombie_killer:33: test 1 -gt 0
./tools/bin/gh_action_zombie_killer:34: page_count=1
./tools/bin/gh_action_zombie_killer:35: set +o xtrace
jq returned        0 runners for page 1
Total count is now        0
Total ids returned:        0
Nothing to kill.  No Termination Required :(

git-phu
git-phu approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@git-phu git-phu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no null (null) :)

@supertopher supertopher temporarily deployed to more-secrets September 13, 2022 19:01 Inactive
@supertopher supertopher merged commit 7de9e25 into master Sep 13, 2022
@supertopher supertopher deleted the toph_fixes_a_terminator_with_no_targets branch September 13, 2022 19:01
@supertopher supertopher mentioned this pull request Sep 14, 2022
Merged
This was referenced Sep 14, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@supertopher @robbinhan
Fixes case where there is nothing to kill (airbytehq#16661)
065205d
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@supertopher @jhammarstedt
Fixes case where there is nothing to kill (airbytehq#16661)
afc74a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-phu git-phu git-phu approved these changes

@c-p-b c-p-b Awaiting requested review from c-p-b

@davinchia davinchia Awaiting requested review from davinchia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supertopher @git-phu @davinchia @c-p-b