Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jobInfoLight API endpoint that excludes attempt information #16682

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

pmossman
Copy link
Contributor

What

Our Temporal workers call the getJobInfo endpoint in order to fetch a connectionID for the current job. However, this endpoint happens to pull in all attempt information, including every log line, and this output can be enormous. We're seeing reliability issues with this API call in Cloud, so this PR adds a lightweight endpoint that can be called instead, that won't include attempt info.

…h can be enormous as it includes all log lines
@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server labels Sep 13, 2022
@pmossman pmossman temporarily deployed to more-secrets September 13, 2022 23:56 Inactive
Copy link
Contributor

@xiaohansong xiaohansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was lightening fast! thanks!

@github-actions github-actions bot added the area/worker Related to worker label Sep 14, 2022
@pmossman pmossman merged commit 1d29672 into master Sep 14, 2022
@pmossman pmossman deleted the parker/get-job-info-light branch September 14, 2022 00:04
@pmossman pmossman temporarily deployed to more-secrets September 14, 2022 00:06 Inactive
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…ytehq#16682)

* add jobInfoLight API endpoint that excludes attempt information, which can be enormous as it includes all log lines

* update replication activity to call new light endpoint
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…ytehq#16682)

* add jobInfoLight API endpoint that excludes attempt information, which can be enormous as it includes all log lines

* update replication activity to call new light endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants