Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Form Refactor - Part Two #16748

Merged
merged 155 commits into from
Oct 7, 2022
Merged

Connection Form Refactor - Part Two #16748

merged 155 commits into from
Oct 7, 2022

Commits on Aug 17, 2022

  1. Work started

    @krishnaglick
    krishnaglick committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    10b4ff1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2f0e83f View commit details
    Browse the repository at this point in the history

  2. Minor cleanup

    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    183087a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b3bc5ff View commit details
    Browse the repository at this point in the history

  4. Some cleanup

    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    85fe161 View commit details
    Browse the repository at this point in the history

  5. Lots moved into context

    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    0e063b1 View commit details
    Browse the repository at this point in the history

  6. WIP, stepping in the right direction

    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    d7ad611 View commit details
    Browse the repository at this point in the history

  7. WIP testing

    @krishnaglick
    krishnaglick committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    468d840 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8834c04 View commit details
    Browse the repository at this point in the history

  2. Post-merge fix

    @krishnaglick
    krishnaglick committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b99d1b3 View commit details
    Browse the repository at this point in the history

  3. Observables!

    @krishnaglick
    krishnaglick committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    25f28ba View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. WIP tests

    @krishnaglick
    krishnaglick committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8272377 View commit details
    Browse the repository at this point in the history

  2. Tests!

    @krishnaglick
    krishnaglick committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e85d301 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    bf6a647 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Aug 25, 2022
    Configuration menu
    Copy the full SHA
    33caf95 View commit details
    Browse the repository at this point in the history

  2. CI test

    @krishnaglick
    krishnaglick committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    68a6ad8 View commit details
    Browse the repository at this point in the history

  3. CI?

    @krishnaglick
    krishnaglick committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9bf2c73 View commit details
    Browse the repository at this point in the history

  4. perhaps

    @krishnaglick
    krishnaglick committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8af1a41 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    4ed21ec View commit details
    Browse the repository at this point in the history

  2. Only show name field during create

    @krishnaglick
    krishnaglick committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    eb24031 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Aug 26, 2022
    Configuration menu
    Copy the full SHA
    1d4b3a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    e41a42f View commit details
    Browse the repository at this point in the history

  2. Fix Build

    @krishnaglick
    krishnaglick committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    dfcd4cc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Aug 29, 2022
    Configuration menu
    Copy the full SHA
    eb54ec2 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    34434d2 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @krishnaglick
    krishnaglick committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    be4001b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Fixing a bug

    @krishnaglick
    krishnaglick committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9d95504 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b53abb8 View commit details
    Browse the repository at this point in the history

  3. Fix failing test

    @krishnaglick
    krishnaglick committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    50bbb3f View commit details
    Browse the repository at this point in the history

  4. Fixes e2e

    @krishnaglick
    krishnaglick committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    65584ca View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    3da331e View commit details
    Browse the repository at this point in the history

  2. Type consolidation

    @krishnaglick
    krishnaglick committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e841140 View commit details
    Browse the repository at this point in the history

  3. useCallback, improvements to connection create onAfter, and removing … 

    …dirty tracking
    @krishnaglick
    krishnaglick committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    92b7c0c View commit details
    Browse the repository at this point in the history

  4. cleanup

    @krishnaglick
    krishnaglick committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8c5558b View commit details
    Browse the repository at this point in the history

  5. Removing an unused prop

    @krishnaglick
    krishnaglick committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d390833 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. errorStatusMessage and mapFormPropsToOperation tests

    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3d094fb View commit details
    Browse the repository at this point in the history

  2. useUniqueFormId and useInitialValues tests

    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3ec2cf2 View commit details
    Browse the repository at this point in the history

  3. Cleanup, onFrequencySelect is moved to its use location, better test … 

    …wrapper, and expanding use of FormError
    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0452458 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    df444fe View commit details
    Browse the repository at this point in the history

  5. Better formSubmit handling for new connection

    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    aec7b10 View commit details
    Browse the repository at this point in the history

  6. Commenting and some cleanup

    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6aabc3b View commit details
    Browse the repository at this point in the history

  7. Comments!

    @krishnaglick
    krishnaglick committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8af9bd2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c9ca5b5 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f809c68 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    61251a0 View commit details
    Browse the repository at this point in the history

  2. Fixing errors from the merge

    @krishnaglick
    krishnaglick committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    208cf78 View commit details
    Browse the repository at this point in the history

  3. mock data cleanup

    @krishnaglick
    krishnaglick committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c7f9afa View commit details
    Browse the repository at this point in the history

  4. Better TODO

    @krishnaglick
    krishnaglick committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cc91839 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e89f762 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    96b12a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    3395828 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4c17657 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    498743a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kc/connection-form-refactor

    @krishnaglick
    krishnaglick authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ed26655 View commit details
    Browse the repository at this point in the history

  3. onFrequencySelect is now always called

    @krishnaglick
    krishnaglick committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    955848c View commit details
    Browse the repository at this point in the history

  4. Edmundo CR

    @krishnaglick
    krishnaglick committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a0beff7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e823d60 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into kc/connection-form-refactor

    @lmossman
    lmossman authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e2dc6e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Remove whitespace

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    7f4916a View commit details
    Browse the repository at this point in the history

  2. Move connection into state so it gets updated

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    19f051c View commit details
    Browse the repository at this point in the history

  3. Consolidate on connection object

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    cc5b939 View commit details
    Browse the repository at this point in the history

  4. Remove ModalCancel throw + form clearing in create submit function

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    e0a2811 View commit details
    Browse the repository at this point in the history

  5. Some cleanup

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    30d81f5 View commit details
    Browse the repository at this point in the history

  6. Fixing error

    @krishnaglick
    krishnaglick committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    aa56b25 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Fixing build error

    @krishnaglick
    krishnaglick committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cecb46d View commit details
    Browse the repository at this point in the history

  2. Rename file

    @krishnaglick
    krishnaglick committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3f948d8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cec5034 View commit details
    Browse the repository at this point in the history

  4. Bridging changes to bring things inline

    @krishnaglick
    krishnaglick committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5ac6baa View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kc/connection-form-refactor' into kc/connection-form-re… 

    …factor-part-two
    @krishnaglick
    krishnaglick committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4961461 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    184732f View commit details
    Browse the repository at this point in the history

  2. Builds and tests run

    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    50df6de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kc/connection-form-refactor' into kc/connection-form-re… 

    …factor-part-two
    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    c9aeb58 View commit details
    Browse the repository at this point in the history

  4. replication view almost works as expected

    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    c375056 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor
    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    a45d98a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'kc/connection-form-refactor' into kc/connection-form-re… 

    …factor-part-two
    @krishnaglick
    krishnaglick committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    c2c9f96 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. About to embark on another huge change! Committing here before I brea… 

    …k more things.
    @krishnaglick
    krishnaglick committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    c9c7fec View commit details
    Browse the repository at this point in the history

  2. slowly, unity

    @krishnaglick
    krishnaglick committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    dfcee9d View commit details
    Browse the repository at this point in the history

  3. Code appears to be working

    @krishnaglick
    krishnaglick committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    31d0ccf View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Merge remote-tracking branch 'origin' into kc/connection-form-refacto… 

    …r-part-two
    @krishnaglick
    krishnaglick committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    793edd0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    20ecdd1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e648c16 View commit details
    Browse the repository at this point in the history

  2. Some minor cleanup

    @krishnaglick
    krishnaglick committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9862aed View commit details
    Browse the repository at this point in the history

  3. Form dirty change tracking

    @krishnaglick
    krishnaglick committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    b93ad8e View commit details
    Browse the repository at this point in the history

  4. WIP styling moving and fixing

    @krishnaglick
    krishnaglick committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    858609a View commit details
    Browse the repository at this point in the history

  5. skip refresh on update if status !== active

    @teallarson
    teallarson committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    efcfcc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Fixing styles

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    bcc2bdf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kc/connection-form-refactor-part-two' of github.com:air… 

    …bytehq/airbyte into kc/connection-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3d0c43e View commit details
    Browse the repository at this point in the history

  3. Minor

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1f5c04e View commit details
    Browse the repository at this point in the history

  4. More cleanup and improvements

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6fd2098 View commit details
    Browse the repository at this point in the history

  5. Rename CreateConnectionContent -> CreateConnection

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    664a14a View commit details
    Browse the repository at this point in the history

  6. refreshSchema moved into the connection form service

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    bcfc57b View commit details
    Browse the repository at this point in the history

  7. Re-add TODO

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    33ce0cc View commit details
    Browse the repository at this point in the history

  8. schemaErrorStatus => schemaError

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    c9baa9a View commit details
    Browse the repository at this point in the history

  9. CreateConnectionName -> CreateConnectionNameField

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    cdcb20d View commit details
    Browse the repository at this point in the history

  10. Logic for readonly vs edit

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4203136 View commit details
    Browse the repository at this point in the history

  11. Added TODO, fixed a re-initialize issue

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7ac8eb1 View commit details
    Browse the repository at this point in the history

  12. Remove unused ConnectionForm component

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a0a9ff5 View commit details
    Browse the repository at this point in the history

  13. Improved refresh schema logic

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f84e214 View commit details
    Browse the repository at this point in the history

  14. undoing some of the cancel work as it felt like the wrong place to do it

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f05a936 View commit details
    Browse the repository at this point in the history

  15. No longer need to know if the status is updating, that info is availa… 

    …ble from the form edit context
    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5b269fb View commit details
    Browse the repository at this point in the history

  16. Move close modal & confirmation modal logic to where it's used

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5c5c3b7 View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary useUnmount

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4578ddd View commit details
    Browse the repository at this point in the history

  18. Cleanup and removal of unused

    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6997f45 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6839074 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    93aaf68 View commit details
    Browse the repository at this point in the history

  2. Somehow missed removing this

    @krishnaglick
    krishnaglick committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5896e66 View commit details
    Browse the repository at this point in the history

  3. Fixing failing test

    @krishnaglick
    krishnaglick committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    89b6e45 View commit details
    Browse the repository at this point in the history

  4. Added missing initialvalues logic. Added connection form service tests.

    @krishnaglick
    krishnaglick committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    599128d View commit details
    Browse the repository at this point in the history

  5. Connection Edit tests!

    @krishnaglick
    krishnaglick committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4b02323 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. connection replication test pt 1

    @krishnaglick
    krishnaglick committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    5b95466 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Moving files to make master merge easier

    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    621c186 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    8a8a084 View commit details
    Browse the repository at this point in the history

  3. Remove snapshot

    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    bc31bde View commit details
    Browse the repository at this point in the history

  4. non-default export

    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    2764a78 View commit details
    Browse the repository at this point in the history

  5. Remove unused

    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a0277af View commit details
    Browse the repository at this point in the history

  6. Minor improvements

    @krishnaglick
    krishnaglick committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    d696b0c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    023b502 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c2e36eb View commit details
    Browse the repository at this point in the history

  2. Edmundo CR.

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ab504ca View commit details
    Browse the repository at this point in the history

  3. name now optional for connection editing

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    4aaa6e3 View commit details
    Browse the repository at this point in the history

  4. Schema refresh errors handled on connection replication view

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9e70086 View commit details
    Browse the repository at this point in the history

  5. schema refreshing logic, confirm catalog dialog abstraction

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    aaaeaae View commit details
    Browse the repository at this point in the history

  6. CreateConnection -> CreateConnectionForm

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    38bb9b6 View commit details
    Browse the repository at this point in the history

  7. form config test cleanup

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f3c3281 View commit details
    Browse the repository at this point in the history

  8. connection replication tab tests

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6dcbbae View commit details
    Browse the repository at this point in the history

  9. Create Connection Form Tests

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    27f790f View commit details
    Browse the repository at this point in the history

  10. Better jest mocking!

    @krishnaglick
    krishnaglick committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e791029 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Fixing issue setting schedule type to manual

    @krishnaglick
    krishnaglick committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4dc6be4 View commit details
    Browse the repository at this point in the history

  2. Tests fixed, and test-utils is better!

    @krishnaglick
    krishnaglick committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4e3b9f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    22397e6 View commit details
    Browse the repository at this point in the history

  4. Changing back to Once

    @krishnaglick
    krishnaglick committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f80e8e6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ddc1573 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ca576d4 View commit details
    Browse the repository at this point in the history

  2. Fixing build from master merge

    @krishnaglick
    krishnaglick committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0b33c07 View commit details
    Browse the repository at this point in the history

  3. Updating snapshots. If these change a lot it may be worth altering th… 

    …e tests to avoid snapshots.
    @krishnaglick
    krishnaglick committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    f9432bd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ea58502 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Edmundo & Lake Code Review Comments

    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ca2d9e4 View commit details
    Browse the repository at this point in the history

  2. Tim CR

    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9510f76 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    330a151 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    82905e7 View commit details
    Browse the repository at this point in the history

  5. Fixing a styling issue

    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d1442ba View commit details
    Browse the repository at this point in the history

  6. ?? is less clever than I thought

    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    fb8fb88 View commit details
    Browse the repository at this point in the history

  7. Form change tracking has been improved to not leave dirty forms aroun… 

    …d. As well as it has been moved into ConnectionFormFields for DRY purposes
    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e95bb38 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:airbytehq/airbyte into kc/connect… 

    …ion-form-refactor-part-two
    @krishnaglick
    krishnaglick committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    562af75 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Update airbyte-webapp/src/hooks/services/ConnectionForm/ConnectionFor… 

    …mService.tsx

Co-authored-by: Lake Mossman <lake@airbyte.io>
    @krishnaglick @lmossman
    krishnaglick and lmossman authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    4abbec4 View commit details
    Browse the repository at this point in the history

  2. Update airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEdi… 

    …tService.test.tsx

Co-authored-by: Lake Mossman <lake@airbyte.io>
    @krishnaglick @lmossman
    krishnaglick and lmossman authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    55e0372 View commit details
    Browse the repository at this point in the history

  3. Update airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPa… 

    …ge/ConnectionReplicationTab.tsx

Co-authored-by: Lake Mossman <lake@airbyte.io>
    @krishnaglick @lmossman
    krishnaglick and lmossman authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    a0c5d9f View commit details
    Browse the repository at this point in the history

  4. DRY out tests

    @krishnaglick
    krishnaglick committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    07a46df View commit details
    Browse the repository at this point in the history

  5. remove unknowns and fix mocked hook to be patch-style (#17698) 

    Co-authored-by: Krishna (kc) Glick <krishna@airbyte.io>
    @lmossman @krishnaglick
    lmossman and krishnaglick authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    ce49bdf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    9812234 View commit details
    Browse the repository at this point in the history

  7. Self-CR

    @krishnaglick
    krishnaglick committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    5c89063 View commit details
    Browse the repository at this point in the history

  8. idk why this was an issue but whatever

    @krishnaglick
    krishnaglick committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c7e760e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into kc/connection-form-refactor-part-two

    @krishnaglick
    krishnaglick authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    7d8685f View commit details
    Browse the repository at this point in the history

  10. Update airbyte-webapp/src/hooks/services/ConnectionForm/ConnectionFor… 

    …mService.test.tsx

Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
    @krishnaglick @teallarson
    krishnaglick and teallarson authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e25f953 View commit details
    Browse the repository at this point in the history

  11. Update airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEdi… 

    …tService.test.tsx

Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
    @krishnaglick @teallarson
    krishnaglick and teallarson authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6443920 View commit details
    Browse the repository at this point in the history