Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicit v0 version of the protocol #16797

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Add an explicit v0 version of the protocol #16797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a8c0b1
Add an explicit v0 version of the protocol
gosusnp Sep 15, 2022
a96c79e
Merge branch 'master' into gosusnp/15989-build_protocol_with_version_…
gosusnp Sep 16, 2022
01a3bac
Merge branch 'master' into gosusnp/15989-build_protocol_with_version_…
gosusnp Sep 21, 2022
154e141
Merge branch 'master' into gosusnp/15989-build_protocol_with_version_…
gosusnp Sep 21, 2022
dda96f6
Merge branch 'master' into gosusnp/15989-build_protocol_with_version_…
gosusnp Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...yte-protocol/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../airbyte_protocol.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Symlinks are rendered like this in github.

15 changes: 15 additions & 0 deletions ...l/protocol-models/src/test/java/io/airbyte/protocol/models/AirbyteProtocolSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@

package io.airbyte.protocol.models;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import io.airbyte.commons.json.Jsons;
import io.airbyte.protocol.models.AirbyteMessage.Type;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
Expand Down Expand Up @@ -33,4 +36,16 @@ void testJsonSchemaType() {
}
}

@Test
void testVersionedObjectsAccessibility() {
final var message = new io.airbyte.protocol.models.AirbyteMessage()
.withType(Type.SPEC);
final var messageV0 = new io.airbyte.protocol.models.v0.AirbyteMessage()
.withType(io.airbyte.protocol.models.v0.AirbyteMessage.Type.SPEC);

// This only works as long as the default version and v0 are equal
final var deserializedMessage = Jsons.deserialize(Jsons.serialize(message), io.airbyte.protocol.models.v0.AirbyteMessage.class);
assertEquals(messageV0, deserializedMessage);
}

}