-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite buildWebBackendConnectionRead to avoid fetching all jobs #16811
rewrite buildWebBackendConnectionRead to avoid fetching all jobs #16811
Conversation
// jobPersistence.listJobsForConnectionWithStatuses orders by created_at desc, so index 0 is the latest. | ||
// there *should* only be a single running sync job for a connection regardless so .get(0) should always be | ||
// what we want. | ||
final Job job = nonTerminalSyncJobsForConnection.get(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit for later: We could do something like nonTerminalSyncJobsForConnection.stream().findFirst()
which returns an optional -- either the first element is there or the list is empty/there is nothing.
} | ||
.catalogId(connectionRead.getSourceCatalogId()); | ||
|
||
if (latestRunningSyncJob.isPresent()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit for later: could do latestRunningSyncJob.ifPresent( -> { //set the fields here })
to avoid the if check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits can be addressed in a follow on once the incident has been resolved.
…bytehq#16811) * rewrite buildWebBackendConnectionRead to avoid fetching all jobs * format * query for latest sync job in addition to latest running sync job * fix query * add test coverage for new methods * simplify optional logic and add another test case
…bytehq#16811) * rewrite buildWebBackendConnectionRead to avoid fetching all jobs * format * query for latest sync job in addition to latest running sync job * fix query * add test coverage for new methods * simplify optional logic and add another test case
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.