Destination BigQuery: add user-agent header #16890

yurii-bidiuk · 2022-09-19T15:20:08Z

What

How

Add user-agent header to Google Cloud Storage and BigQuery API builders.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

github-actions · 2022-09-19T15:20:58Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-bigquery

...ation-bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryUtils.java

github-actions · 2022-09-20T10:06:33Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-bigquery

yurii-bidiuk · 2022-09-20T10:11:51Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089274913
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089274913
🐛 https://gradle.com/s/nzsogvxzzmlp6

Build Failed

Test summary info:

Could not find result summary

yurii-bidiuk · 2022-09-20T10:12:04Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089276225
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089276225
🐛 https://gradle.com/s/rbpexl6yt2dc6

Build Failed

Test summary info:

Could not find result summary

yurii-bidiuk · 2022-09-20T10:15:17Z

destination-bigquery-denormalized extends from destination-bigquery and uses the same Stage and BigQuery API setup, so this PR also fixes #16616

yurii-bidiuk · 2022-09-20T10:56:07Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089540594
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089540594
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-20T10:56:15Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089541402
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089541402
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

github-actions · 2022-09-20T10:56:48Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-bigquery-denormalized

github-actions · 2022-09-20T12:07:20Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-bigquery-denormalized

github-actions · 2022-09-22T10:23:33Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-bigquery

alexandr-shegeda

LGTM. we can proceed with publishing and merging without airbyte review

yurii-bidiuk · 2022-09-26T14:02:33Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3128378466
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3128378466
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

yurii-bidiuk · 2022-09-26T14:02:42Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3128378895
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3128378895
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

github-actions · 2022-09-26T14:03:14Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery
destination-bigquery-denormalized

yurii-bidiuk · 2022-09-26T15:58:20Z

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3129219501

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

yurii-bidiuk · 2022-09-26T15:58:35Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/3129221586

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery-denormalized	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…ithub.com/airbytehq/airbyte into bidiuk/16615-dest-bigquery-add-user-agent

github-actions · 2022-09-26T16:55:00Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

destination-bigquery-denormalized
destination-bigquery

* Destiantion BigQuery: add user-agent header * fixed comments * fix tests * refactor code * refactoring * bump version * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

yurii-bidiuk requested a review from alexandr-shegeda September 19, 2022 15:20

github-actions bot added the area/connectors Connector related issues label Sep 19, 2022

octavia-squidington-iii added the connectors/destination/bigquery label Sep 19, 2022

alexandr-shegeda reviewed Sep 19, 2022

View reviewed changes

...ation-bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryUtils.java Outdated Show resolved Hide resolved

yurii-bidiuk requested a review from VitaliiMaltsev September 20, 2022 10:18

yurii-bidiuk changed the title ~~Destiantion BigQuery: add user-agent header~~ Destination BigQuery: add user-agent header Sep 20, 2022

alexandr-shegeda approved these changes Sep 26, 2022

View reviewed changes

yurii-bidiuk added 6 commits September 26, 2022 16:58

Destiantion BigQuery: add user-agent header

46172b2

fixed comments

c4bce6a

fix tests

a2c7f44

refactor code

9ba4ea4

refactoring

f5e119b

bump version

645aa77

yurii-bidiuk force-pushed the bidiuk/16615-dest-bigquery-add-user-agent branch from e4c33b2 to 645aa77 Compare September 26, 2022 14:02

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 26, 2022

octavia-squidington-iii added 3 commits September 26, 2022 16:45

auto-bump connector version [ci skip]

112ce19

auto-bump connector version [ci skip]

fff1179

Merge branch 'bidiuk/16615-dest-bigquery-add-user-agent' of https://g…

d1b46c7

…ithub.com/airbytehq/airbyte into bidiuk/16615-dest-bigquery-add-user-agent

octavia-squidington-iii temporarily deployed to more-secrets September 26, 2022 16:56 Inactive

yurii-bidiuk marked this pull request as ready for review September 26, 2022 17:30

octavia-squidington-iii added the connectors/destination/bigquery-denormalized label Sep 26, 2022

yurii-bidiuk merged commit e07bd6b into master Sep 26, 2022

yurii-bidiuk deleted the bidiuk/16615-dest-bigquery-add-user-agent branch September 26, 2022 17:31

This was referenced Sep 27, 2022

Bump Airbyte version from 0.40.9 to 0.40.10 #17285

Closed

Bump Airbyte version from 0.40.9 to 0.40.10 #17359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination BigQuery: add user-agent header #16890

Destination BigQuery: add user-agent header #16890

yurii-bidiuk commented Sep 19, 2022 •

edited

Loading

github-actions bot commented Sep 19, 2022

github-actions bot commented Sep 20, 2022

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 22, 2022

alexandr-shegeda left a comment

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 26, 2022

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Sep 26, 2022

Destination BigQuery: add user-agent header #16890

Destination BigQuery: add user-agent header #16890

Conversation

yurii-bidiuk commented Sep 19, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Sep 19, 2022

github-actions bot commented Sep 20, 2022

yurii-bidiuk commented Sep 20, 2022 • edited by github-actions bot Loading

Build Failed

yurii-bidiuk commented Sep 20, 2022 • edited by github-actions bot Loading

Build Failed

yurii-bidiuk commented Sep 20, 2022

yurii-bidiuk commented Sep 20, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 20, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 22, 2022

alexandr-shegeda left a comment

Choose a reason for hiding this comment

yurii-bidiuk commented Sep 26, 2022 • edited by github-actions bot Loading

Build Passed

yurii-bidiuk commented Sep 26, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Sep 26, 2022

yurii-bidiuk commented Sep 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Sep 26, 2022 • edited by github-actions bot Loading

github-actions bot commented Sep 26, 2022

yurii-bidiuk commented Sep 19, 2022 •

edited

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Sep 26, 2022 •

edited by github-actions bot

Loading