Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🧹 Update Inter font to use variable fonts #16926

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

edmundito
Copy link
Contributor

@edmundito edmundito commented Sep 20, 2022

What

Relates to #16239

This updates the webapp to use the variable version of Inter over specific font styles.

How

Applies the variable woff2 version for regular and italic fonts. woff2 is compatible with most modern desktop released after 2016, which is enough for what the webapp needs to support. It also falls back to standard fonts when it cannot load the font.

https://caniuse.com/?search=woff2

@edmundito edmundito requested a review from a team as a code owner September 20, 2022 14:20
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 20, 2022
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍
Also tested locally

Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally, works as expected and gosh does this font render more sharp on my machine :D

@edmundito edmundito merged commit 810d3a1 into master Sep 22, 2022
@edmundito edmundito deleted the edmundito/var-inter-font branch September 22, 2022 13:15
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Update Inter font styles to import variable version

* Rename regular SCSS font var to primary

* Remove non-standard css rule, add public to pre-commit linting
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Update Inter font styles to import variable version

* Rename regular SCSS font var to primary

* Remove non-standard css rule, add public to pre-commit linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants