🪟 🐛 Schedule type cron bug fix #17058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
changed the title
krishnaglick
approved these changes
Sep 22, 2022
| values.scheduleType = values.scheduleData?.basicSchedule | ||
| ? ConnectionScheduleType.basic | ||
| : ConnectionScheduleType.manual; | ||
|
|
There was a problem hiding this comment.
This was accidentally re-added during a merge with the connection form refactor work.
This was referenced Sep 22, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* remove inaccurate and unneeded setting of schedule type * Fixing & adding tests Co-authored-by: KC <krishna@airbyte.io>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* remove inaccurate and unneeded setting of schedule type * Fixing & adding tests Co-authored-by: KC <krishna@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes frontend OC bug where users cannot set a schedule to cron
Resolves https://github.com/airbytehq/airbyte-cloud/issues/2841
How
removes an unneeded (and broken) check for schedule type and uses what's actually in the form instead.