Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to low-code documentation #17121

Merged
merged 8 commits into from
Sep 27, 2022
Merged

Updates to low-code documentation #17121

merged 8 commits into from
Sep 27, 2022

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Sep 25, 2022

What

A few small updates to the low-code documentation

How

  • Add section descriptions to index page
  • Add more links to make it easier to navigate
  • Move documentation on substreams to their own section for clarity
  • Reword some of the sentences

Recommended reading order

  1. docs/connector-development/config-based/index.md
  2. docs/connector-development/config-based/overview.md
  3. docs/connector-development/config-based/stream-slicers.md
  4. docs/connector-development/config-based/substreams.md
  5. docs/connector-development/config-based/tutorial/0-getting-started.md

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 25, 2022
@@ -0,0 +1,47 @@
# Substreams
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from stream-slicers.md

@girarda girarda changed the title Alex/update lowcode docs Updates to low-code documentation Sep 25, 2022
@@ -1,22 +1,31 @@
:warning: This framework is in alpha stage. Support is not in production and is available only to select users. :warning:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add warning to the index

| [Pagination](./pagination.md) | [Page limit](./pagination.md#page-increment)<br/>[Offset](./pagination.md#offset-increment)<br/>[Cursor](./pagination.md#cursor) |
| [Authentication](./authentication.md) | [Header based](./authentication.md#ApiKeyAuthenticator)<br/>[Bearer](./authentication.md#BearerAuthenticator)<br/>[Basic](./authentication.md#BasicHttpAuthenticator)<br/>[OAuth](./authentication.md#OAuth) |
| Sync mode | Full refresh<br/>Incremental |
| Schema discovery | Only static schemas |
| Schema discovery | Static schemas |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove superfluous word

2. Paginator: Describes how to navigate through the API's pages
3. Record selector: Describes how to extract records from a HTTP response
4. Stream Slicer: Describes how to partition the stream, enabling incremental syncs and checkpointing
2. [Paginator](./pagination.md): Describes how to navigate through the API's pages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add links

@@ -209,5 +205,5 @@ pagination_strategy:
The following connectors can serve as example of what production-ready config-based connectors look like

- [Greenhouse](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-greenhouse)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to update the greenhouse link because the production connector is using low-code

@@ -209,5 +205,5 @@ pagination_strategy:
The following connectors can serve as example of what production-ready config-based connectors look like

- [Greenhouse](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-greenhouse)
- [Sendgrid](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-sendgrid)
- [Sentry](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-sentry)
- [Sendgrid](https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-sendgrid/source_sendgrid/sendgrid.yaml)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update links to point to the yaml file for sendgrid and sentry because the connector is not using low-code

@@ -118,54 +118,10 @@ the resulting stream slices are
]
```

### Substream slicer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to substreams.md to make it easier to find

@girarda girarda marked this pull request as ready for review September 25, 2022 22:35
Copy link
Contributor

@misteryeo misteryeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added one small suggestion on the warning

@@ -1,22 +1,31 @@
:warning: This framework is in alpha stage. Support is not in production and is available only to select users. :warning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:warning: This framework is in alpha stage. Support is not in production and is available only to select users. :warning:
:warning: This framework is in [alpha](https://docs.airbyte.com/project-overview/product-release-stages/#alpha). It is still in active development and may include backward-incompatible changes. Please share feedback and requests directly with us at feedback@airbyte.io :warning:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @misteryeo!

Co-authored-by: Andy <andy@airbyte.io>
@girarda girarda merged commit 4c5f6aa into master Sep 27, 2022
@girarda girarda deleted the alex/update_lowcode_docs branch September 27, 2022 02:05
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Update docs

* move substreams to another file

* Update link

* rename

* link to alpha definition

* Update docs/connector-development/config-based/index.md

Co-authored-by: Andy <andy@airbyte.io>

Co-authored-by: Andy <andy@airbyte.io>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Update docs

* move substreams to another file

* Update link

* rename

* link to alpha definition

* Update docs/connector-development/config-based/index.md

Co-authored-by: Andy <andy@airbyte.io>

Co-authored-by: Andy <andy@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants