Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit constructor injection for activity implementations #17152

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Use explicit constructor injection for activity implementations #17152

merged 1 commit into from
Sep 27, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Consistent injection of dependencies into annotated singletons

How

  • Use explicit constructors for injection into Temporal activity implementations
  • Remove use of Lombok for constructor generation in Temporal activity implementations

Recommended reading order

  1. *.java

Tests

  • Project builds locally, passing all unit tests and static analysis
  • Ran locally via docker-compose and verified that a sync works

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Sep 26, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets September 26, 2022 17:34 Inactive
colesnodgrass
colesnodgrass approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@colesnodgrass colesnodgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets September 26, 2022 19:24 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 8945f16 into master Sep 27, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/constructor-injection branch September 27, 2022 12:44
This was referenced Sep 27, 2022
Closed
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@jdpgrailsdev @robbinhan
Use explicit constructor injection for activity implementations (airb…
c67b68c 
…ytehq#17152)
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@jdpgrailsdev @jhammarstedt
Use explicit constructor injection for activity implementations (airb…
f9e6ede 
…ytehq#17152)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@gosusnp gosusnp gosusnp approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdpgrailsdev @colesnodgrass @gosusnp @benmoriceau