-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 cron/workspace-cleaner: only run task for docker environments #17168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The require part looks good to me. I am not sure about the config itself, we had some discussions about that.
@benmoriceau, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to add the new env variable to the file kube/overlays/resources/cron.yml
.
And we will need to make sure that the helm chart have this value as well when they got created.
@benmoriceau Added to kube/resources/cron.yml in bbe301b |
Updated to use micronaut environments cc @jdpgrailsdev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ytehq#17168) * dont run cleanup on kubernetes * use the micronaut way™ * add env var to kube resource * use micronaut environment instead * no need for the env var
What
Running cron on a kubernetes environment was causing an error when executing the WorkspaceCleaner:
How
Since this is only intended to run on docker contexts, use the micronaut environment to determine if the task should run.