Remove default value from namespaceDefinitionType #17177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
pmossman
force-pushed
the
parker/remove-default-namespace-format
branch
from
0b3ae36
to
a77e2ea
Compare
mfsiega-airbyte
approved these changes
Sep 26, 2022
|
The failing acceptance test looks to be unrelated, it's been failing in master for a while, so I'm going to merge this in order to unblock an OC fix |
This was referenced Sep 27, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* remove default value from namespaceDefinitionType * fix test * switch some tests to use PATCH-style connection update * add default logic to connection creation Co-authored-by: Michael Siega <michael@airbyte.io>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* remove default value from namespaceDefinitionType * fix test * switch some tests to use PATCH-style connection update * add default logic to connection creation Co-authored-by: Michael Siega <michael@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug where the Destination Namespace can be reset to the default of 'source'.
Now that we can send partial updates for Connections, we need to remove the default value from namespaceDefinitionType so that partial updates that leave this value alone aren't defaulted to an unintended value.
How