Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jakarta annotations #17251

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Switch to Jakarta annotations package to avoid licensing/trademark issues.

How

  • javax.inject -> jakarta.inject for Singleton, Inject and Named annotations.

More Details

Micronaut states the following with regards to the two packages:

Due to trademark restrictions imposed on the javax.* namespace, the Micronaut framework has switched from the javax.inject to the jakarta.inject annotations as the set of annotations that’s included by default with the Framework. We recommend that you switch your application to the new annotations. It should only be a matter of changing the imports. For current uses of javax.inject.Provider, we recommend switching to io.micronaut.context.BeanProvider.

This is based off of Oracle's trademark of the javax package space:

Oracle's Java trademarks are the property of Oracle and the Eclipse Foundation has no rights to use them. The implications of this are as follows:

  1. The javax package namespace may be used within Jakarta EE specifications but may be used "as is" only. No modification to the javax package namespace is permitted within Jakarta EE component specifications. Jakarta EE specifications that continue to use the javax package namespace must remain TCK compatible with the corresponding Java EE specifications.
  2. Jakarta EE component specifications using the javax package namespace may be omitted entirely from future Jakarta EE Platform specifications.
  3. Specification names must be changed from a "Java EE" naming convention to a "Jakarta EE" naming convention. This includes acronyms such as EJB, JPA or JAX-RS.

Tests

  • Project builds locally/all unit tests pass
  • Project runs locally via docker-compose
  • Connector created and sync successfully executed via local instance

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets September 27, 2022 13:43 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 896c2c9 into master Sep 27, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/jakarta-annotations branch September 27, 2022 15:18
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants