Replace WorkerPlane with Micronaut environments #17286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpgrailsdev
requested review from
colesnodgrass,
gosusnp,
benmoriceau,
pmossman and
alovew
github-actions
bot
added
area/platform
gosusnp
approved these changes
Sep 27, 2022
| @@ -163,7 +163,7 @@ public void onApplicationEvent(final ServiceReadyEvent event) { | |||
| log.info("Starting worker factory..."); | |||
| workerFactory.start(); | |||
|
|
|||
| log.info("Application initialized (mode = {}).", workerPlane); | |||
| log.info("Application initialized."); | |||
There was a problem hiding this comment.
Do we see the environment.getActiveNames somewhere? Otherwise, I think it could be worth logging for debugging purpose.
benmoriceau
approved these changes
Sep 27, 2022
|
@gosusnp @benmoriceau I realized that I also need to update the helm charts and Kube acceptance test charts. I will do that before merging. |
FYI, the infra team is working on removing the kube acceptance test charts: https://airbytehq-team.slack.com/archives/C02TXT37Y3Y/p1664298082438109. One less chart to update! |
|
@gosusnp @benmoriceau PR has been updated with the fixed charts. |
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Replace WorkerPlane with Micronaut environments * Set proper environment for airbyte-workers
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Replace WorkerPlane with Micronaut environments * Set proper environment for airbyte-workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
airbyte-workersservice with a Micronaut-based environment.How
WorkerPlaneenumerationRecommended reading order
WorkerMode.javaApplicationBeanFactory.javaApiClientBeanFactory.javaApplicationInitializer.java.envCloud will need to be updated after merge to ensure that it uses the proper environment string (changed from
control->control-plane)Tests