Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor cleanup of airbyte-metrics-reporter #17337

Merged
merged 1 commit into from
Sep 28, 2022
Merged

minor cleanup of airbyte-metrics-reporter #17337

merged 1 commit into from
Sep 28, 2022

Conversation

colesnodgrass
Copy link
Member

What

  • minor clean-up of metrics-reporter

How

  • replace our custom Procedure interface with java's Callable interface
  • remove lombok annotations
  • replace two variables period and timeUnit with one variable duration
  • add final keywords where applicable

Recommended reading order

  1. x.java

@colesnodgrass colesnodgrass changed the title minor cleanup of airbytemetrics-reporter minor cleanup of airbyte-metrics-reporter Sep 28, 2022
@colesnodgrass colesnodgrass merged commit d8b07fa into master Sep 28, 2022
@colesnodgrass colesnodgrass deleted the cole/clean-up-toemit branch September 28, 2022 17:42
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 28, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@colesnodgrass @robbinhan
minor cleanup (airbytehq#17337)
be48ece
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@colesnodgrass @jhammarstedt
minor cleanup (airbytehq#17337)
df82663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@jdpgrailsdev jdpgrailsdev Awaiting requested review from jdpgrailsdev

@benmoriceau benmoriceau Awaiting requested review from benmoriceau

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @gosusnp