🎉 Source Youtube analytics - added custom backoff logic #17454

midavadim · 2022-09-30T12:32:09Z

What

Resolving: https://github.com/airbytehq/alpha-beta-issues/issues/270

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-09-30T12:32:16Z

All committers have signed the CLA.

…be-analytics-backoff # Conflicts: # docs/integrations/sources/youtube-analytics.md

midavadim · 2022-09-30T12:55:18Z

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3158914466
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3158914466
🐛 https://gradle.com/s/ado5zvndinx34

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >120...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
================== 4 failed, 25 passed in 12638.12s (3:30:38) ==================

bazarnov · 2022-09-30T13:47:42Z

Please bump the version of the Dokerfile to 0.1.3

midavadim · 2022-10-03T18:13:17Z

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3176424043
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3176424043
🐛 https://gradle.com/s/77a5vy5sgb3t4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 5 failed, 24 passed in 294.82s (0:04:54) ===================

midavadim · 2022-10-03T18:33:28Z

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3176551009
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3176551009
🐛 https://gradle.com/s/ymnldihzk2h4o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 14 passed, 13 errors in 46.48s ===================

midavadim · 2022-10-04T11:11:21Z

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3181635423
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3181635423
🐛 https://gradle.com/s/ejbju6ak4qlts

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
================== 4 failed, 25 passed in 6708.30s (1:51:48) ===================

midavadim · 2022-10-04T19:31:06Z

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3184915373
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/3184915373
Python tests coverage:

Name                                   Stmts   Miss  Cover
----------------------------------------------------------
source_youtube_analytics/__init__.py       2      0   100%
source_youtube_analytics/source.py       160     24    85%
----------------------------------------------------------
TOTAL                                    162     24    85%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

bazarnov

The last comment would be about unit_test coverage: it's only 85%, I think it would be good to have at least 90% before releasing to GA.

midavadim · 2022-10-07T14:25:22Z

/publish connector=connectors/source-youtube-analytics

🕑 Publishing the following connectors:
connectors/source-youtube-analytics
https://github.com/airbytehq/airbyte/actions/runs/3205469880

Connector	Did it publish?	Were definitions generated?
connectors/source-youtube-analytics	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

) * added custom backoff logic based on youtube analytics limits * updated docs * updated docs * bumped connector version * added configuration option for test purpose only * added comments * added unittest * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

added custom backoff logic based on youtube analytics limits

63a914b

github-actions bot added the area/connectors Connector related issues label Sep 30, 2022

octavia-squidington-iv added the connectors/source/youtube-analytics label Sep 30, 2022

updated docs

2bc2197

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 30, 2022

midavadim requested a review from bazarnov September 30, 2022 12:37

midavadim added 2 commits September 30, 2022 15:40

Merge remote-tracking branch 'origin/master' into midavadim/270-youtu…

c5c3eb1

…be-analytics-backoff # Conflicts: # docs/integrations/sources/youtube-analytics.md

updated docs

fc1d9bf

bazarnov approved these changes Sep 30, 2022

View reviewed changes

bumped connector version

946645a

midavadim temporarily deployed to more-secrets September 30, 2022 16:03 Inactive

added configuration option for test purpose only

8ab6053

midavadim temporarily deployed to more-secrets October 4, 2022 19:28 Inactive

midavadim requested review from bazarnov and lazebnyi October 4, 2022 19:36

added comments

bc12538

midavadim temporarily deployed to more-secrets October 4, 2022 19:54 Inactive

bazarnov approved these changes Oct 5, 2022

View reviewed changes

added unittest

8885d20

midavadim temporarily deployed to more-secrets October 7, 2022 14:13 Inactive

lazebnyi approved these changes Oct 7, 2022

View reviewed changes

auto-bump connector version [ci skip]

b70febc

midavadim merged commit 4a74740 into master Oct 7, 2022

midavadim deleted the midavadim/270-youtube-analytics-backoff branch October 7, 2022 15:54

octavia-squidington-iii mentioned this pull request Oct 7, 2022

Bump Airbyte version from 0.40.13 to 0.40.14 #17762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Youtube analytics - added custom backoff logic #17454

🎉 Source Youtube analytics - added custom backoff logic #17454

midavadim commented Sep 30, 2022 •

edited by bazarnov

Loading

CLAassistant commented Sep 30, 2022 •

edited

Loading

midavadim commented Sep 30, 2022 •

edited by github-actions bot

Loading

bazarnov commented Sep 30, 2022

midavadim commented Oct 3, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 3, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 4, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 4, 2022 •

edited by github-actions bot

Loading

bazarnov left a comment

midavadim commented Oct 7, 2022 •

edited by github-actions bot

Loading

🎉 Source Youtube analytics - added custom backoff logic #17454

🎉 Source Youtube analytics - added custom backoff logic #17454

Conversation

midavadim commented Sep 30, 2022 • edited by bazarnov Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Sep 30, 2022 • edited Loading

midavadim commented Sep 30, 2022 • edited by github-actions bot Loading

Build Failed

bazarnov commented Sep 30, 2022

midavadim commented Oct 3, 2022 • edited by github-actions bot Loading

Build Failed

midavadim commented Oct 3, 2022 • edited by github-actions bot Loading

Build Failed

midavadim commented Oct 4, 2022 • edited by github-actions bot Loading

Build Failed

midavadim commented Oct 4, 2022 • edited by github-actions bot Loading

Build Passed

bazarnov left a comment

Choose a reason for hiding this comment

midavadim commented Oct 7, 2022 • edited by github-actions bot Loading

midavadim commented Sep 30, 2022 •

edited by bazarnov

Loading

CLAassistant commented Sep 30, 2022 •

edited

Loading

midavadim commented Sep 30, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 3, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 3, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 4, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 4, 2022 •

edited by github-actions bot

Loading

midavadim commented Oct 7, 2022 •

edited by github-actions bot

Loading