Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Twilio: Lookback_window config #17478

Merged
merged 5 commits into from
Sep 30, 2022
Merged

🐛 Source Twilio: Lookback_window config #17478

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0b8514
🐛 Source Twilio: Lookback_window config
artem1205 Sep 30, 2022
d34044a
🐛 Source Twilio: update docs
artem1205 Sep 30, 2022
72e4711
🐛 Source Twilio: update specs
artem1205 Sep 30, 2022
cebab8a
🐛 Source Twilio: test fix backward compatibility
artem1205 Sep 30, 2022
35a4f9e
auto-bump connector version [ci skip]
octavia-squidington-iii Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-twilio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ COPY main.py ./
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.10
LABEL io.airbyte.version=0.1.11
LABEL io.airbyte.name=airbyte/source-twilio
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ connector_image: airbyte/source-twilio:dev
tests:
spec:
- spec_path: "source_twilio/spec.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.11"
connection:
- config_path: "secrets/config.json"
status: "succeed"
Expand Down
262 changes: 135 additions & 127 deletions airbyte-integrations/connectors/source-twilio/integration_tests/expected_records.txt
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-twilio/source_twilio/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
incremental_stream_kwargs = {
"authenticator": auth,
"start_date": config["start_date"],
"lookback_window": config["lookback_window"],
"lookback_window": config.get("lookback_window", 0)
}

# Fix for `Date range specified in query is partially or entirely outside of retention window of 400 days`
Expand Down
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-twilio/source_twilio/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
"description": "How far into the past to look for records. (in minutes)",
"examples": [60],
"default": 0,
"minimum": 0,
"maximum": 576000,
"type": "integer",
"order": 4
}
Expand Down
4 changes: 3 additions & 1 deletion docs/integrations/sources/twilio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ For more information, see [the Twilio docs for rate limitations](https://support
## Changelog

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------------------------------------------------------------------------------------------------ |
|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------|
| 0.1.11 | 2022-09-30 | [17478](https://github.com/airbytehq/airbyte/pull/17478) | Add lookback_window parameters |
| 0.1.10 | 2022-09-29 | [17410](https://github.com/airbytehq/airbyte/pull/17410) | Migrate to per-stream states |
| 0.1.9 | 2022-09-26 | [17134](https://github.com/airbytehq/airbyte/pull/17134) | Add test data for Message Media and Conferences |
| 0.1.8 | 2022-08-29 | [16110](https://github.com/airbytehq/airbyte/pull/16110) | Add state checkpoint interval |
| 0.1.7 | 2022-08-26 | [15972](https://github.com/airbytehq/airbyte/pull/15972) | Shift start date for stream if it exceeds 400 days |
| 0.1.6 | 2022-06-22 | [14000](https://github.com/airbytehq/airbyte/pull/14000) | Update Records stream schema and align tests with connectors' best practices |
Expand Down