Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Replication Summary length #17546

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Check Replication Summary length #17546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/ReplicationActivityImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
public class ReplicationActivityImpl implements ReplicationActivity {

private static final Logger LOGGER = LoggerFactory.getLogger(ReplicationActivityImpl.class);
private static final int MAX_TEMPORAL_MESSAGE_SIZE = 2 * 1024 * 1024;

private final Optional<ContainerOrchestratorConfig> containerOrchestratorConfig;
private final WorkerConfigs workerConfigs;
Expand Down Expand Up @@ -156,7 +157,14 @@ public StandardSyncOutput replicate(final JobRunConfig jobRunConfig,
final ReplicationOutput attemptOutput = temporalAttempt.get();
final StandardSyncOutput standardSyncOutput = reduceReplicationOutput(attemptOutput);

LOGGER.info("sync summary: {}", standardSyncOutput);
final String standardSyncOutputString = standardSyncOutput.toString();
LOGGER.info("sync summary: {}", standardSyncOutputString);
if (standardSyncOutputString.length() > MAX_TEMPORAL_MESSAGE_SIZE) {
LOGGER.error("Sync ouput exceeds the max temporal message size of {}, actual is {}.", MAX_TEMPORAL_MESSAGE_SIZE,
standardSyncOutputString.length());
} else {
LOGGER.info("Sync summary length: {}", standardSyncOutputString.length());
}

return standardSyncOutput;
},
Expand Down