Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Add integration for Osano/GDPR #17565

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Oct 4, 2022

What

Closing https://github.com/airbytehq/airbyte-cloud/issues/2426

This adds the full implementation for GDPR and Osano into the product. It will address the following:

  • Loads the Osano script/styles only in Cloud now (as per discussion with Andy)
  • Add a "Cookie Preferences" button in the sidebar in Cloud settings that will open the Osano drawer. This button will only be shown if Osano is switched to "active" (i.e. production) and thus show the consent dialogs.
  • For users in GDRP affected countries make the newsletter an opt-in instead of opt-out during sign-up

@timroes timroes requested a review from a team as a code owner October 4, 2022 16:11
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 4, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, code LGTM

Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also did not test locally, but looks good to me 👍

"Europe/Vilnius",
"Europe/Warsaw",
"Europe/Zagreb",
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: is browser timezone a sufficient way to enforce GDPR? Seems a bit unreliable to me, but I don't have a better suggestion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is not a really foolproof way. Luckily this is really only used to determine the default state of the newsletter flag and such I think it's an "okay enough" approach, without requiring to get a third party geo location service in place (which would be the better approach detecting by IP location). Osano itself for showing the right consent banner actually uses a proper IP based approach, so it's really only for the default state of this one switch we're needing to use this weaker approach.

@timroes timroes merged commit 23274b5 into master Oct 5, 2022
@timroes timroes deleted the tim/gdpr-integration branch October 5, 2022 11:19
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants