Various Micronaut-related cleanup items #17611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosusnp
reviewed
Oct 5, 2022
| @@ -31,6 +31,19 @@ application { | |||
| applicationDefaultJvmArgs = ['-XX:+ExitOnOutOfMemoryError', '-XX:MaxRAMPercentage=75.0'] | |||
| } | |||
|
|
|||
| Properties env = new Properties() | |||
| rootProject.file('.env.dev').withInputStream { env.load(it) } | |||
There was a problem hiding this comment.
Why are we getting .env.dev and not .env?
There was a problem hiding this comment.
@gosusnp The theory is that this is being used for quick, local testing and therefore use the dev version. However, if the .env.dev is not reliable, etc, this could easily be switched.
benmoriceau
approved these changes
Oct 10, 2022
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
airbyte-workersRecommended reading order
build.gradleapplication.yamlmicronaut-banner.txt