Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postgres (source and destination) field titles #1765

Merged
merged 4 commits into from
Jan 25, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Jan 21, 2021

This removes the need for the locales hack which hardcodes some of these values as a special case:

  "form.postgres_host": "Host",
  "form.postgres_port": "Port",
  "form.postgres_username": "User",
  "form.postgres_password": "Password",
  "form.postgres_database": "DB Name",
  "form.postgres_schema": "Schema",

Once this is approved I'll build and push the connector so the build will pass here.

@jrhizor jrhizor requested a review from cgardens January 21, 2021 18:23
@jrhizor
Copy link
Contributor Author

jrhizor commented Jan 25, 2021

Fixed merge issues and building/publishing source-postgres and destination-postgres.

Once those are pushed to Docker Hub I'll make sure the image checker condition passes and merge.

@jrhizor jrhizor merged commit 227e709 into master Jan 25, 2021
@jrhizor jrhizor deleted the jrhizor/add-postgres-titles branch January 25, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants