Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎨 Fix design of log view #17765

Merged
merged 2 commits into from
Oct 10, 2022
Merged

🪟 🎨 Fix design of log view #17765

merged 2 commits into from
Oct 10, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Oct 8, 2022

What

This fixes a couple of issues and design improvements on the MainInfo and AttemptDetails:

  • I noticed the arrow behind at the end of the collapse isn't rotating when opening. This was caused by the further nested rule having had more specificity and thus always applied. I pulled out the CSS for the arrow and restructured the file a bit to solve that. Also this solved the problem that hovering over any item the arrow will become visible on ALL other items as well.
  • I moved the "Last Attempt: " into the same row as the actual data, so it's looking a bit less crowded for failed logs (see below screenshot). Therefore I moved that line into the AttemptDetails component controlled by a new property whether there are multiple attempts. This also makes this code a bit cleaner, since so far that "Last Attempt" was also checked for reset jobs where it could not happen. and the component we rendered below it wasn't meant to be rendered behind a "Last Attempt" in case it would ever have shown.

screenshot-20221008-175449

@timroes timroes requested a review from a team as a code owner October 8, 2022 16:06
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 8, 2022
className?: string;
attempt: AttemptRead;
configType?: JobConfigType;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This property wasn't used anywhere inside the component so I removed it.

Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@timroes timroes merged commit fb523af into master Oct 10, 2022
@timroes timroes deleted the tim/job-list-design-fix branch October 10, 2022 16:20
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants