decouple the secrets helper from connectors, to support secrets in ot… #17771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her types of configs
davinchia
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Looks good to me. Appreciate updating the comments.
@benmoriceau looks these classes best, so definitely want him to approve before merging.
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…her types of configs (airbytehq#17771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support secrets in other config types apart from just connectors.
This will let us re-use the existing secrets management logic for secrets that live in other places -- e.g., a webhook operation config table.
There are other possible refactors here, but this is a minimal change to enable code reuse to support webhook operations.
How
Replace the
ConnectorSpecificationin the SecretsHelper API with the underlying JsonNode.We eventually always pull the JsonNode out, so this just pushes it one layer higher to make the SecretsHelper more generic.
Recommended reading order
airbyte-config/config-persistence/src/main/java/io/airbyte/config/persistence/split_secrets/SecretsHelpers.java