Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Move links out of config #17837

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Oct 11, 2022

What

Part of #10955

Move links out of the config, since they are just a static list and not part of the actual configuration. Extracting this into it's own PR, since it touches a couple of files.

@timroes timroes added team/compose area/frontend Related to the Airbyte webapp ui/services labels Oct 11, 2022
@timroes timroes requested a review from a team as a code owner October 11, 2022 13:06
@github-actions github-actions bot added the area/platform issues related to the platform label Oct 11, 2022
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@timroes timroes merged commit 7c8f8a8 into master Oct 11, 2022
@timroes timroes deleted the tim/move-links-out-of-config branch October 11, 2022 14:40
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants