Introduce secrets management into workspace persistence #17851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
mfsiega-airbyte
requested review from
a team,
terencecho and
davinchia
and removed request for
a team
terencecho
approved these changes
Oct 11, 2022
| * | ||
| * @param workspace - The configuration of the workspace | ||
| * @throws JsonValidationException - throws is the workspace is invalid | ||
| * @throws IOException - you never know when you IO |
There was a problem hiding this comment.
@terencecho I can't claim credit for this one, I stole it from elsewhere in this file :)
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce secrets management into workspace persistence.
This prepares for a follow-up PR which will introduce actually secrets -- webhook auth tokens -- into the workspace table.
This PR should be a behavioural no-op.
How
ConfigRepository.writeStandardWorkspace->ConfigRepository.writeStandardWorkspaceNoSecrets, plus documentation that it shouldn't be used directly.ConfigRepository.getStandardWorkspace->ConfigRepository.getStandardWorkspaceNoSecretsfor clarity.SecretsRespository[Reader|Writer]Recommended reading order
airbyte-config/config-persistence/src/main/java/io/airbyte/config/persistence/SecretsRepositoryReader.javaairbyte-config/config-persistence/src/main/java/io/airbyte/config/persistence/SecretsRepositoryWriter.javaairbyte-server/src/main/java/io/airbyte/server/handlers/WorkspacesHandler.javaThe rest is mostly no-op refactor.