Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove logging command line #17925

Merged
merged 1 commit into from
Oct 12, 2022
Merged

remove logging command line #17925

merged 1 commit into from
Oct 12, 2022

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Oct 12, 2022 •
edited
Loading

What

remove the set -x that was exposing the airbyte DB password

@benmoriceau benmoriceau marked this pull request as ready for review October 12, 2022 23:45
@benmoriceau benmoriceau temporarily deployed to more-secrets October 12, 2022 23:46 Inactive
evantahler
evantahler approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔐

jdpgrailsdev
jdpgrailsdev approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau merged commit a0e1fdf into master Oct 12, 2022
@benmoriceau benmoriceau deleted the bmoric/fix-extra-log branch October 12, 2022 23:53
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@benmoriceau @jhammarstedt
remove logging command line (airbytehq#17925)
f19830b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmoriceau @evantahler @jdpgrailsdev