Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source google-analytics-v4: fix pagination #17943

Merged

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/787

How

Retrieve the next page token from the first and the only object in the reports item of the response, not the root item.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 13, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 13, 2022

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/3241957610
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/3241957610
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       296     20    93%
------------------------------------------------------------
TOTAL                                      298     20    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1351    453    66%

Build Passed

Test summary info:

All Passed

@davydov-d
Copy link
Collaborator Author

davydov-d commented Oct 13, 2022

/publish connector=connectors/source-google-analytics-v4

🕑 Publishing the following connectors:
connectors/source-google-analytics-v4
https://github.com/airbytehq/airbyte/actions/runs/3242192339


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-v4

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 234089e into master Oct 13, 2022
@davydov-d davydov-d deleted the ddavydov/#787-oncall-google-analytics-fix-pagination branch October 13, 2022 12:28
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* airbytehq#787 oncall - source google-analytics: fix pagination

* source google-analytics-v4: upd changelog

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants