add source s3 back to catalog #17997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
sherifnada
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks back we hid S3 from the catalog in 17472 while a longer term security fix for the connector was addressed.
Since the issue where S3 could be configured w/o TLS on certain endpoints was addressed in #17481 , we can now go ahead with restoring it to the catalog for customers again. After rolling this out to OSS it will then need to be release to cloud as well in a similar fashion to what we did originally.
More context in the slack thread: https://airbytehq-team.slack.com/archives/C02UF50V9HA/p1665682359276099?thread_ts=1665171759.043279&cid=C02UF50V9HA