-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octavia-cli: Added flag to control whether to reset the streams or not #18337
octavia-cli: Added flag to control whether to reset the streams or not #18337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! The main change we want before merging this in is to keep the default behavior the same.
airbyte-server/src/main/java/io/airbyte/server/handlers/WebBackendConnectionsHandler.java
Outdated
Show resolved
Hide resolved
octavia-cli/integration_tests/configurations/connections/poke_to_pg/configuration.yaml
Outdated
Show resolved
Hide resolved
Hello 👋, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
@marcosmarxm i'll let you handle the process of merging this commit. feel free to ping me if you need anything! |
Everything looks good for merging! Thank you for your contribution and your patience. It's contributors like you that help make our open source community so great! |
Slight oversight on my end. I think because this field is set to required, it is failing some of the other integration tests. I can put up a fix for this (either making the field optional or updating the integration tests). In the meantime I will revert this PR so the builds are able to pass. I will update this PR and the corresponding issues with my progress. |
Fix for the failing integration tests: #20093 |
What
Fixes #17968
How
Added an already existing flag on the API to be available to octavia-cli.
Recommended reading order
octavia-cli/octavia_cli/generate/templates/connection.yaml.j2
octavia-cli/octavia_cli/apply/resources.py
🚨 User Impact 🚨
N/A
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.