-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Source: Wikipedia Pageviews #18343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, please send a message in the Slack channel to get support for your test failure.
airbyte-integrations/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/spec.yaml
Show resolved
Hide resolved
...ns/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/wikipedia_pageviews.yaml
Outdated
Show resolved
Hide resolved
...ns/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/wikipedia_pageviews.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
...ntegrations/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/schemas/TODO.md
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-wikipedia-pageviews/integration_tests/catalog.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/spec.yaml
Outdated
Show resolved
Hide resolved
...ns/connectors/source-wikipedia-pageviews/source_wikipedia_pageviews/wikipedia_pageviews.yaml
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-wikipedia-pageviews |
/test connector=connectors/source-wikipedia-pageviews
Build FailedTest summary info:
|
Passing all tests except this error:
|
@marcosmarxm @girarda could you look into this failing test for me and what could be causing it please? |
you must remove the |
Year is not in my spec.yml right? Me and Brian looked at this and couldn't find it. |
It looks like its trying to run a test against the exchange rates example project. |
@evwltrs could you try to run |
I'll run that in a moment, I can't recall what the source page document is though? |
where can I find the gradlew binary? |
|
you must check what test are failing, you need to read the logs. |
Passing all tests should be good to go 👍 |
Tested fully within airbyte OSS, works perfectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evwltrs thanks for the contribution, I'll publish later the connector.
/test connector=connectors/source-wikipedia-pageviews
Build FailedTest summary info:
|
@marcosmarxm how can I fix this, doesn't happen on my local machine |
Don't worry @evwltrs I'm taking a look! :D |
/test connector=connectors/source-wikipedia-pageviews
Build PassedTest summary info:
|
/publish connector=connectors/source-wikipedia-pageviews
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-wikipedia-pageviews
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Add the wikipedia pageviews connector using the low code CDK.
Hacktoberfest: airbytehq/connector-contest#90
Currently not passing 1 test so draft status.
If anyone could spot why this is coming up, please leave a comment :D