-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source - K6 Cloud [low-code cdk] #18393
Conversation
Thanks for the contribution! Someone will review it during this week. If you have any questions please create comments so the reviewer can focus on those points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments and ready to go! :)
airbyte-integrations/connectors/source-k6-cloud/source_k6_cloud/k6_cloud.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-k6-cloud/source_k6_cloud/k6_cloud.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about the schema.
airbyte-integrations/connectors/source-k6-cloud/source_k6_cloud/schemas/tests.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-k6-cloud/source_k6_cloud/k6_cloud.yaml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-k6-cloud/source_k6_cloud/k6_cloud.yaml
Outdated
Show resolved
Hide resolved
Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉 |
/test connector=connectors/source-k6-cloud
Build FailedTest summary info:
|
/test connector=connectors/source-k6-cloud
Build PassedTest summary info:
|
/publish connector=connectors/source-k6-cloud
if you have connectors that successfully published but failed definition generation, follow step 4 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haithem-souala
* add streams * lint * add changelog * add doc * clean * lint * fix comments * fix schema * fix schema * fix comments * fix comments * fix doc * initial commit * add streams * fix tests * add doc * lint * lint * lint * add laucnhdarkly to source def * Revert "add laucnhdarkly to source def" This reverts commit 0039166. * add k6 cloud to source def * add k6 cloud to source spec Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
What
Streams
🚨 User Impact 🚨
N/A
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance