Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector-builder server stub #18410

Merged
merged 87 commits into from
Nov 9, 2022
Merged

Connector-builder server stub #18410

Show file tree
Hide file tree
Changes from 84 commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
7736109
init
girarda Oct 18, 2022
ad5abf0
bad copy/paste
girarda Oct 18, 2022
aca3534
move to top level
girarda Oct 18, 2022
75ad65c
Revert "move to top level"
girarda Oct 19, 2022
77197a1
attempt to wire up connector builder frontend to server
lmossman Oct 19, 2022
b05daa8
copy from octaviacli
girarda Oct 19, 2022
8543034
fix connection to builder server
lmossman Oct 19, 2022
7fad84f
update
girarda Oct 19, 2022
4cad0d5
Merge branch 'master' into alex/connector_builder
girarda Oct 19, 2022
f745d28
delete
girarda Oct 19, 2022
795523b
Update
girarda Oct 19, 2022
f9258a7
delete python-version
girarda Oct 19, 2022
2419f54
Revert "delete python-version"
girarda Oct 19, 2022
5022710
setup python
girarda Oct 19, 2022
3360dad
install python
girarda Oct 19, 2022
faf6eae
rename
girarda Oct 19, 2022
39efd07
kube stuff
girarda Oct 20, 2022
33e895b
Install python
girarda Oct 20, 2022
88d846a
missing kube file
girarda Oct 20, 2022
e8da375
rename
girarda Oct 20, 2022
1172f14
Update files
girarda Oct 20, 2022
82e98c7
Update bumpversion
girarda Oct 20, 2022
0e16c33
install python
girarda Oct 20, 2022
e1e01b7
try with different entrypoint
girarda Oct 20, 2022
0820e52
Merge branch 'master' into alex/connector_builder
girarda Oct 20, 2022
71516c8
rename container
girarda Oct 20, 2022
a10d7ba
point to docker-compose.yaml file
girarda Oct 20, 2022
742913b
derp
girarda Oct 20, 2022
66fa528
copy acceptance_test.sh
girarda Oct 20, 2022
c7cf7e5
merge
girarda Oct 21, 2022
4b6e5db
copy from acceptance tests
girarda Oct 21, 2022
7bc8ada
delete cruft
girarda Oct 21, 2022
9832f6f
update
girarda Oct 25, 2022
8d26e6e
remove application env
girarda Oct 25, 2022
8db977e
merge
girarda Oct 25, 2022
a2e4ac9
Merge branch 'master' into alex/connector_builder_fastapi
girarda Oct 26, 2022
0ddbaec
Merge branch 'lmossman/connector-builder-wire-frontend-to-server' int…
girarda Oct 26, 2022
a70e0f6
reset
girarda Oct 26, 2022
77aa027
reset to master
girarda Oct 26, 2022
099cecf
update
girarda Oct 26, 2022
9cee657
skip comprehensive incremental tests
girarda Oct 26, 2022
05ea9db
Revert "skip comprehensive incremental tests"
girarda Oct 26, 2022
dabce80
Merge branch 'master' into alex/connector_builder_fastapi
girarda Oct 27, 2022
ba02a4a
reset to master
girarda Oct 27, 2022
46fa3bc
remove cruft
girarda Oct 27, 2022
24fc6a6
merge master
girarda Nov 3, 2022
f8dffee
delete superfluous steps
girarda Nov 3, 2022
0cf0a9c
update port to 8003
girarda Nov 3, 2022
bdd5c7a
reset to master
girarda Nov 3, 2022
98c4a41
Update publish docker
girarda Nov 3, 2022
57dda04
move openapi spec to airbyte-connector-builder
girarda Nov 3, 2022
7dc72f4
point to openapi spec
girarda Nov 3, 2022
71cae24
dont expose the connector builder to localhost
girarda Nov 3, 2022
2d91e18
reset FE components to master
girarda Nov 3, 2022
3d15749
Don't deploy the connector-builder
girarda Nov 3, 2022
beac3d4
Revert "Don't deploy the connector-builder"
girarda Nov 3, 2022
2e0bd72
Revert "Revert "Don't deploy the connector-builder""
girarda Nov 3, 2022
52f2f7a
comment out more things related to connector builder server
girarda Nov 3, 2022
39a5da2
more attempts at removing the connector builder
girarda Nov 3, 2022
f8ed162
comment out more things
girarda Nov 3, 2022
9c88d96
Apply suggestions from code review
girarda Nov 3, 2022
23579ba
Update airbyte-webapp/src/config/configProviders.ts
girarda Nov 3, 2022
cc44f00
update
girarda Nov 3, 2022
0c66a45
Merge branch 'master' into alex/connector_builder_fastapi
girarda Nov 3, 2022
b2d802b
rename
girarda Nov 3, 2022
6ccd6c6
indent
girarda Nov 3, 2022
e46a837
Revert "move openapi spec to airbyte-connector-builder"
girarda Nov 3, 2022
91db24f
Revert "rename"
girarda Nov 3, 2022
abf562f
Revert "Revert "rename""
girarda Nov 3, 2022
7c94331
point to wrong file in case it fixes the build
girarda Nov 3, 2022
787d0c0
point to right openapi file
girarda Nov 3, 2022
75ff3ad
Revert "Revert "move openapi spec to airbyte-connector-builder""
girarda Nov 4, 2022
46a4d25
point to moved file
girarda Nov 4, 2022
08953b4
fix path
girarda Nov 4, 2022
4e184d0
Update from master
girarda Nov 4, 2022
2f51292
Merge branch 'master' into alex/connector_builder_fastapi
girarda Nov 4, 2022
1c43c13
newline
girarda Nov 4, 2022
ed9fea0
Add failing test
girarda Nov 4, 2022
245b0b2
Revert "Add failing test"
girarda Nov 4, 2022
d941984
comment
girarda Nov 4, 2022
0f048d3
update commented requires
girarda Nov 4, 2022
460720a
Add a comment
girarda Nov 4, 2022
c683e83
2022
girarda Nov 9, 2022
75fd366
Merge branch 'master' into alex/connector_builder_fastapi
girarda Nov 9, 2022
6e7019d
rename to connector-builder-server
girarda Nov 9, 2022
78d50ca
typo
girarda Nov 9, 2022
2a439af
Merge branch 'master' into alex/connector_builder_fastapi
girarda Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,11 @@ serialize =
[bumpversion:file:octavia-cli/install.sh]

[bumpversion:file:octavia-cli/setup.py]

[bumpversion:file:connector-builder/Dockerfile]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the module to so its version gets bumped with the others

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that to get a connector builder update, I have to upgrade my whole airbyte instance? in that case we should probably recommend that people develop lowcode connectors in a separate instance from their prod one. Just a note for the docs in the future


[bumpversion:file:connector-builder/README.md]

[bumpversion:file:connector-builder/install.sh]

[bumpversion:file:connector-builder/setup.py]
1 change: 1 addition & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION=0.35.15.001
### AIRBYTE SERVICES ###
TEMPORAL_HOST=airbyte-temporal:7233
INTERNAL_API_HOST=airbyte-server:8001
#CONNECTOR_BUILDER_API_HOST=airbyte-connector-builder:80 #FIXME: Uncomment this when enabling the connector-builder
WEBAPP_URL=http://localhost:8000/
# Although not present as an env var, required for webapp configuration.
API_URL=/api/v1/
Expand Down
1 change: 1 addition & 0 deletions .env.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ HACK_LOCAL_ROOT_PARENT=/tmp
WEBAPP_URL=http://localhost:8000/
API_URL=/api/v1/
INTERNAL_API_HOST=airbyte-server:8001
#CONNECTOR_BUILDER_API_HOST=airbyte-connector-builder:8003 #FIXME: Uncomment this when enabling the connector-builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is commented out for now because this is stubbed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I doubt there would be any harm to exposing the env variable, but we can just turn this on at the same time as we enable the server

SYNC_JOB_MAX_ATTEMPTS=3
SYNC_JOB_MAX_TIMEOUT_DAYS=3
WORKERS_MICRONAUT_ENVIRONMENTS=control-plane
Expand Down
Loading