🎉New Source: TMDb [low-code cdk] #18561

btkcodedev · 2022-10-27T16:43:30Z

What

Developing new connector for the source: TMDb

Resolves
🎉 New Source: TMDb

How

Developed using low-code cdk

Streams

Movies_alternative_titles
Movies_changes
Movies_credits
Movies_details
Movies_external_ids
Movies_images
Movies_keywords
Movies_latest
Movies_lists
Movies_now_playing
Movies_popular
Movies_recommentations
Movies_releases_dates
Movies_reviews
Movies_similar_movies
Movies_top_rated
Movies_translations
Movies_upcoming
Movies_videos
Movies_watch_providers

🚨 User Impact 🚨

No breaking changes, Just addition of new source

New Connector: TMDb

Community member or Airbyter

Tests

Integration & Acceptance

Result: Passed
Run ID: 5f6361892718fd5a37bf53cd76049397cdbaa531

marcosmarxm · 2022-10-28T00:16:19Z

Hello @btkcodedev thanks for the contribution! Please request my review when the PR is ready.

btkcodedev · 2022-10-28T08:51:50Z

@marcosmarxm It's ready for review

marcosmarxm

Some comments!

airbyte-integrations/connectors/source-tmdb/source_tmdb/tmdb.yaml

airbyte-integrations/connectors/source-tmdb/source_tmdb/spec.yaml

airbyte-integrations/connectors/source-tmdb/integration_tests/catalog.json

airbyte-integrations/connectors/source-tmdb/integration_tests/sample_config.json

airbyte-integrations/connectors/source-tmdb/integration_tests/invalid_config.json

marcosmarxm · 2022-11-04T08:53:48Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

btkcodedev · 2022-11-05T17:46:33Z

@marcosmarxm @harshithmullapudi All comments resolved.
Review from community needed.

marcosmarxm

Some comments, but the connector is working! :) Just some final details.

airbyte-integrations/connectors/source-tmdb/source_tmdb/tmdb.yaml

btkcodedev · 2022-11-08T15:58:52Z

@marcosmarxm All comments resolved. Thanks!

marcosmarxm

Some comments.

airbyte-integrations/connectors/source-tmdb/source_tmdb/tmdb.yaml

airbyte-integrations/connectors/source-tmdb/source_tmdb/spec.yaml

…r corrections

btkcodedev · 2022-11-09T15:50:02Z

@marcosmarxm All comments resolved and tested.

marcosmarxm · 2022-11-09T22:27:13Z

@btkcodedev can you share the output of ./gradlew airbyte-integrations:connectors:source-tmdb:integrationTest I'm running with config:

{
    "api_key": "my api key",
    "movie_id": "550",
    "query": "Marvel"
  }

and it isn't working.

btkcodedev · 2022-11-10T15:16:16Z

@btkcodedev can you share the output of ./gradlew airbyte-integrations:connectors:source-tmdb:integrationTest I'm running with config:
{
    "api_key": "my api key",
    "movie_id": "550",
    "query": "Marvel"
  }
and it isn't working.

Oo my bad, I didn't add language to the required spec, But was added to my secret config.
No problem, fixed it, Just add language: en-US in config. It will work
Recent test resulted in a pass state.

btkcodedev · 2022-11-10T16:09:49Z

@marcosmarxm My config:
{
"api_key": "API_KEY",
"movie_id": "550",
"query": "Marvel",
"language": "en-US"
}

And all comments resolved! :)

btkcodedev · 2022-11-11T23:21:20Z

@marcosmarxm Could somebody please review my PR, I've worked so hard to get this much of streams right. Please get it merged before deadline

btkcodedev · 2022-11-12T17:48:13Z

Anyonee???

marcosmarxm · 2022-11-16T14:01:00Z

@bthecoderdev I'm review today. Don't worry about the deadline.

marcosmarxm

Thanks @btkcodedev

CLAassistant · 2022-11-16T18:49:48Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ marcosmarxm
❌ bthecoderdev
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

marcosmarxm · 2022-11-16T18:50:11Z

/test connector=connectors/source-tmdb

🕑 connectors/source-tmdb https://github.com/airbytehq/airbyte/actions/runs/3482221383
✅ connectors/source-tmdb https://github.com/airbytehq/airbyte/actions/runs/3482221383
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:88: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:364: The previous connector image could not be retrieved.
======================== 26 passed, 3 skipped in 44.97s ========================

marcosmarxm · 2022-11-16T19:29:48Z

/publish connector=connectors/source-tmdb

🕑 Publishing the following connectors:
connectors/source-tmdb
https://github.com/airbytehq/airbyte/actions/runs/3482492214

Connector	Did it publish?	Were definitions generated?
connectors/source-tmdb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Init: New Source: TMDb * chore: Added documentation * Chore: All Comments Resolved * Added language config for filtering, All comomments resolved * Update Doc URL * add tmdb to source def and format files * Removed unwanted authenticator, Added request params and configs * cleansed lint * feat: Added pagination, refactor: moved example to spec.yaml and minor corrections * fix: change required in spec.yaml, corrections to docs * removed unwanted file change * remove movies_changes * auto-bump connector version Co-authored-by: btkcodedev <btk.codedev@gmail.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Init: New Source: TMDb

b9d6c7a

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 27, 2022

octavia-squidington-iv added community connectors/source/tmdb labels Oct 27, 2022

btkcodedev added 2 commits October 27, 2022 22:15

chore: Added documentation

5198a0e

Merge branch 'master' into tmdb

766e762

marcosmarxm added the hacktober label Oct 27, 2022

Merge branch 'master' into tmdb

c3dba4b

btkcodedev marked this pull request as ready for review October 28, 2022 08:51

octavia-squidington-iv added the bounty label Oct 28, 2022

marcosmarxm requested changes Oct 28, 2022

View reviewed changes

Merge branch 'master' into tmdb

98745fc

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

marcosmarxm assigned harshithmullapudi Nov 4, 2022

btkcodedev added 3 commits November 5, 2022 23:12

Chore: All Comments Resolved

ff394db

Merge branch 'tmdb' of https://github.com/btkcodedev/airbyte into tmdb

47f2187

Merge branch 'master' into tmdb

a642870

btkcodedev added 2 commits November 5, 2022 23:43

Added language config for filtering, All comomments resolved

d96646a

Merge branch 'tmdb' of https://github.com/btkcodedev/airbyte into tmdb

e8f0fd3

btkcodedev requested a review from marcosmarxm November 5, 2022 18:15

btkcodedev and others added 2 commits November 6, 2022 00:01

Update Doc URL

7f72f10

add tmdb to source def and format files

972678c

marcosmarxm requested changes Nov 7, 2022

View reviewed changes

btkcodedev added 2 commits November 8, 2022 21:17

Removed unwanted authenticator, Added request params and configs

40e2435

Resolve merge conflict

608e5a8

cleansed lint

5a3ed5a

btkcodedev requested a review from marcosmarxm November 8, 2022 15:58

Merge branch 'master' into tmdb

e5714ab

marcosmarxm requested changes Nov 8, 2022

View reviewed changes

btkcodedev added 2 commits November 9, 2022 21:08

feat: Added pagination, refactor: moved example to spec.yaml and mino…

a113f10

…r corrections

Merge branch 'tmdb' of https://github.com/btkcodedev/airbyte into tmdb

46eec09

btkcodedev requested a review from marcosmarxm November 9, 2022 15:48

fix: change required in spec.yaml, corrections to docs

c2e2301

octavia-squidington-iv added the connectors/source/tvmaze-schedule label Nov 10, 2022

removed unwanted file change

9052b6c

marcosmarxm approved these changes Nov 16, 2022

View reviewed changes

remove movies_changes

2e61946

Merge branch 'master' into tmdb

c763c6c

auto-bump connector version

f136a34

marcosmarxm merged commit 310b518 into airbytehq:master Nov 16, 2022

github-actions bot mentioned this pull request Nov 17, 2022

Bump helm chart version reference to 0.40.44 #19546

Merged

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉New Source: TMDb [low-code cdk] #18561

🎉New Source: TMDb [low-code cdk] #18561

btkcodedev commented Oct 27, 2022

marcosmarxm commented Oct 28, 2022

btkcodedev commented Oct 28, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 4, 2022

btkcodedev commented Nov 5, 2022

marcosmarxm left a comment

btkcodedev commented Nov 8, 2022

marcosmarxm left a comment

btkcodedev commented Nov 9, 2022

marcosmarxm commented Nov 9, 2022

btkcodedev commented Nov 10, 2022

btkcodedev commented Nov 10, 2022

btkcodedev commented Nov 11, 2022 •

edited

Loading

btkcodedev commented Nov 12, 2022

marcosmarxm commented Nov 16, 2022

marcosmarxm left a comment •

edited

Loading

CLAassistant commented Nov 16, 2022

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

🎉New Source: TMDb [low-code cdk] #18561

🎉New Source: TMDb [low-code cdk] #18561

Conversation

btkcodedev commented Oct 27, 2022

What

How

Streams

Recommended reading order

🚨 User Impact 🚨

Community member or Airbyter

Tests

marcosmarxm commented Oct 28, 2022

btkcodedev commented Oct 28, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 4, 2022

btkcodedev commented Nov 5, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

btkcodedev commented Nov 8, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

btkcodedev commented Nov 9, 2022

marcosmarxm commented Nov 9, 2022

btkcodedev commented Nov 10, 2022

btkcodedev commented Nov 10, 2022

btkcodedev commented Nov 11, 2022 • edited Loading

btkcodedev commented Nov 12, 2022

marcosmarxm commented Nov 16, 2022

marcosmarxm left a comment • edited Loading

Choose a reason for hiding this comment

CLAassistant commented Nov 16, 2022

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

btkcodedev commented Nov 11, 2022 •

edited

Loading

marcosmarxm left a comment •

edited

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading