🐛 Source HubSpot: fix property scopes #18624

artem1205 · 2022-10-28T19:16:39Z

What

Resolving #833

How

Check if user has special property permissions per stream

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

artem1205 · 2022-10-28T19:17:29Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3347949067
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3347949067
🐛 https://gradle.com/s/dlx6qfwbw7xj2

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 ERROR integration_tests/test_associations.py::test_incremental_read_fetches_associations[api_key]
	 ERROR integration_tests/test_associations.py::test_incremental_read_fetches_associations[oauth]
	 �[31m========================= �[33m1 warning�[0m, �[31m�[1m2 errors�[0m�[31m in 1.43s�[0m�[31m =========================�[0m

artem1205 · 2022-11-01T14:17:09Z

Waiting for PR 18546

artem1205 · 2022-11-07T14:21:58Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3411147153
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3411147153
🐛 https://gradle.com/s/cl5wvqqspukxk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contai...
============ 1 failed, 34 passed, 29 warnings in 385.88s (0:06:25) =============

artem1205 · 2022-11-07T17:34:53Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3412637875
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3412637875
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         94     21    78%
source_hubspot/streams.py       847    267    68%
-------------------------------------------------
TOTAL                          1022    298    71%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       847     79    91%
source_hubspot/source.py         94     18    81%
-------------------------------------------------
TOTAL                          1022    100    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

All Passed

bazarnov

LGTM with minor log message corrections.

airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

artem1205 · 2022-11-07T19:06:05Z

/publish connector=connectors/source-hubspot

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/3413257538

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…nent * master: 🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028 Stream returns AirbyteMessages (#18572) 🎉 New Source - Recruitee [low-code SDK] (#18671) 🎉 New source: Breezometer [low-code cdk] (#18650) Check disabled connections after protocol update (#18990) Simple default replication worker refactor (#19002) 🎉 New Source: Visma e-conomic (#18595) 🎉 New Source: Fastbill (#18593) Bmoric/extract state api (#18980) 🎉 New Source: Zapier Supported Storage (#18442) 🎉 New source: Klarna (#18385) `AirbyteEstimateTraceMessage` (#18875) Extract source definition api (#18977) [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411) 🐛 Source HubSpot: fix property scopes (#18624) Ensure that only 6-character hex values are passed to monaco editor (#18943)

artem1205 added 2 commits October 28, 2022 21:12

🐛 Source HubSpot: fix property scopes

dfe41bd

🐛 Source HubSpot: bump version

174559a

github-actions bot added the area/connectors Connector related issues label Oct 28, 2022

octavia-squidington-iv added the connectors/source/hubspot label Oct 28, 2022

🐛 Source Hubspot: fix properties for auth

f7fafae

artem1205 requested review from arsenlosenko, bazarnov and roman-yermilov-gl November 7, 2022 17:56

bazarnov approved these changes Nov 7, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

🐛 Source Hubspot: fix log messages

db48247

auto-bump connector version

95f6823

artem1205 merged commit d88a81c into master Nov 7, 2022

artem1205 deleted the artem1205/833-source-hubspot-check branch November 7, 2022 19:31

octavia-squidington-iii temporarily deployed to more-secrets November 7, 2022 19:32 Inactive

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source HubSpot: fix property scopes #18624

🐛 Source HubSpot: fix property scopes #18624

artem1205 commented Oct 28, 2022

artem1205 commented Oct 28, 2022 •

edited by github-actions bot

Loading

artem1205 commented Nov 1, 2022

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading

bazarnov left a comment

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading

🐛 Source HubSpot: fix property scopes #18624

🐛 Source HubSpot: fix property scopes #18624

Conversation

artem1205 commented Oct 28, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

artem1205 commented Oct 28, 2022 • edited by github-actions bot Loading

Build Failed

artem1205 commented Nov 1, 2022

artem1205 commented Nov 7, 2022 • edited by github-actions bot Loading

Build Failed

artem1205 commented Nov 7, 2022 • edited by github-actions bot Loading

Build Passed

bazarnov left a comment

Choose a reason for hiding this comment

artem1205 commented Nov 7, 2022 • edited by github-actions bot Loading

artem1205 commented Oct 28, 2022 •

edited by github-actions bot

Loading

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading

artem1205 commented Nov 7, 2022 •

edited by github-actions bot

Loading