Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Destination Google Sheets: Fix empty headers list #18729

Merged
merged 6 commits into from
Nov 1, 2022
Merged

🐛Destination Google Sheets: Fix empty headers list #18729

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea0e95b
Fix empty headers list
lazebnyi Oct 31, 2022
68a4b9a
Updated PR number
lazebnyi Oct 31, 2022
aa14d9c
Merge branch 'master' into lazebnyi/344-destination-google-sheets-fix…
lazebnyi Oct 31, 2022
24e6e9e
Bumped version
lazebnyi Nov 1, 2022
c4e88cb
Merge master to branch
lazebnyi Nov 1, 2022
7b7e55b
auto-bump connector version
octavia-squidington-iii Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-google-sheets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ cat integration_tests/test_data/messages.txt | docker run --rm -v $(pwd)/secrets
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
pip install .'[tests]'
```
### Unit Tests
To run unit tests locally, from the connector directory run:
Expand Down
3 changes: 2 additions & 1 deletion ...ntegrations/connectors/destination-google-sheets/destination_google_sheets/spreadsheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ def set_headers(self, stream_name: str, headers_list: List[str]):
Sets headers belonging to the input stream
"""
stream: Worksheet = self.open_worksheet(stream_name)
stream.update_row(1, headers_list)
if headers_list:
stream.update_row(1, headers_list)

def index_cols(self, stream: Worksheet) -> Mapping[str, int]:
"""
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/google-sheets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,6 @@ You cannot create more than 200 worksheets within single spreadsheet.

| Version | Date | Pull Request | Subject |
| ------- | ---------- | -------------------------------------------------------- | ----------------------------------- |
| 0.1.2 | 2022-10-31 | [18729](https://github.com/airbytehq/airbyte/pull/18729) | Fix empty headers list |
| 0.1.1 | 2022-06-15 | [14751](https://github.com/airbytehq/airbyte/pull/14751) | Yield state only when records saved |
| 0.1.0 | 2022-04-26 | [12135](https://github.com/airbytehq/airbyte/pull/12135) | Initial Release |