🎉 New Source: Dynamodb #18750

itaseskii · 2022-11-01T02:04:45Z

What

Adds Dynamodb source connector airbytehq/connector-contest#149

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-11-01T02:04:51Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ itaseskii
✅ marcosmarxm
❌ itaseski

itaseski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

marcosmarxm · 2022-11-01T13:27:03Z

@itaseskii can you check your commits, look one was made with another user.

marcosmarxm · 2022-11-02T23:29:31Z

@itaseskii I'll review this tomorrow! thsanks for the contribution

marcosmarxm · 2022-11-04T08:55:08Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm

Asking some help to review the protocol change.

marcosmarxm · 2022-11-08T01:35:39Z

...e-protocol/protocol-models/src/main/java/io/airbyte/protocol/models/JsonSchemaPrimitive.java

@@ -8,6 +8,7 @@ public enum JsonSchemaPrimitive {

  STRING,
  NUMBER,
+  INTEGER,


@airbytehq/protocol-reviewers can someone take a look into this change?

@marcosmarxm Out of curiosity, why do we need an integer type when it already has NUMBER that encompasses integer values? See https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Number.html for more details.

Hey @jdpgrailsdev I have added this as a first class JsonSchemaPrimitive for the reason that Number is used for storing both decimal and integeter numbers and in the IncrementalUtil.compareCursor() method it is used for comparing doubles instead of integers. Since Dynamodb can support incremental syncs using epoch timestamps I needed the ability to compare two integers for the state transmission.

@itaseskii You can get an integer value from a Number, so I'm not sure why we would need an explicit INTEGER value in the protocol. I'm also not sure why it would matter if the code is comparing two Number objects. Could you point out where in the pull request you are doing this comparison or where in the existing code you think it would be an issue to compare two Number objects instead of integers?

@jdpgrailsdev The implementation in IncrementalUtil.compareCursor() is not comparing Numbers but Doubles when a JsonSchemaPrimitive.Number is provided. But even so there is a point that it shouldn't be an issue comparing two integers using Double.compare(Double.parseDouble(original), Double.parseDouble(candidate)) since they can easily be parsed to doubles if the value is provided as String. I have reverted the addition of the Integer type to the JsonSchemaPrimitive enum and thanks a lot for your input!

marcosmarxm · 2022-11-08T02:38:29Z

/test connector=connectors/source-dynamodb

🕑 connectors/source-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3415890819
✅ connectors/source-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3415890819
No Python unittests run

Build Passed

Test summary info:

All Passed

…into source-dynamodb

marcosmarxm · 2022-11-08T21:40:43Z

@itaseskii waiting the protocol feedback, besides that the connector looks solid!

marcosmarxm · 2022-11-14T00:32:17Z

/test connector=connectors/source-dynamodb

🕑 connectors/source-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3457626655
✅ connectors/source-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3457626655
No Python unittests run

Build Passed

Test summary info:

All Passed

marcosmarxm

Thanks @itaseskii

marcosmarxm · 2022-11-14T13:35:46Z

/publish connector=connectors/source-dynamodb

🕑 Publishing the following connectors:
connectors/source-dynamodb
https://github.com/airbytehq/airbyte/actions/runs/3461930065

Connector	Did it publish?	Were definitions generated?
connectors/source-dynamodb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

RealChrisSean · 2022-11-18T19:23:44Z

Hello @itaseskii can you please update your profile with your email?

If you prefer to DM me instead, please dm with the following:

Full name
Email
link to this PR
Thanks!

* dynamodb source connector * code cleanup * code cleanup * add date type filtering * add doc * revert integer schema primitive * add dynamodb to source def * auto-bump connector version Co-authored-by: itaseski <itaseski@debian-BULLSEYE-live-builder-AMD64> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

itaseskii and others added 3 commits October 30, 2022 16:22

dynamodb source connector

a60e777

Merge branch 'master' into source-dynamodb

71a5202

code cleanup

a9d29d3

itaseskii requested a review from a team as a code owner November 1, 2022 02:04

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol labels Nov 1, 2022

octavia-squidington-iv added the connectors/source/dynamodb label Nov 1, 2022

itaseskii changed the title ~~🎉 New source: Dynamodb~~ 🎉 New Source: Dynamodb Nov 1, 2022

itaseskii added the hacktober label Nov 1, 2022

marcosmarxm requested changes Nov 8, 2022

View reviewed changes

itaseskii added 3 commits November 8, 2022 09:26

code cleanup

6a0db3a

Merge branch 'source-dynamodb' of https://github.com/itaseskii/airbyte …

65a4e67

…into source-dynamodb

add date type filtering

1a77007

itaseskii added 2 commits November 9, 2022 13:30

add doc

2490c6f

revert integer schema primitive

23e845b

octavia-squidington-iv removed area/protocol area/platform issues related to the platform labels Nov 11, 2022

add dynamodb to source def

8d55892

marcosmarxm approved these changes Nov 14, 2022

View reviewed changes

auto-bump connector version

20ea1be

Merge branch 'master' into source-dynamodb

b4f3a5b

marcosmarxm merged commit a2d24b5 into airbytehq:master Nov 14, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm mentioned this pull request Nov 21, 2022

🎉 New source: DynamoDB #14555

Closed

37 tasks

marcosmarxm mentioned this pull request Feb 13, 2024

New Source: Dynamo DB #3561

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Dynamodb #18750

🎉 New Source: Dynamodb #18750

itaseskii commented Nov 1, 2022

CLAassistant commented Nov 1, 2022 •

edited

Loading

marcosmarxm commented Nov 1, 2022

marcosmarxm commented Nov 2, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

marcosmarxm Nov 8, 2022

jdpgrailsdev Nov 9, 2022

itaseskii Nov 9, 2022 •

edited

Loading

jdpgrailsdev Nov 10, 2022

itaseskii Nov 11, 2022

marcosmarxm commented Nov 8, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 8, 2022

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

RealChrisSean commented Nov 18, 2022

🎉 New Source: Dynamodb #18750

🎉 New Source: Dynamodb #18750

Conversation

itaseskii commented Nov 1, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Nov 1, 2022 • edited Loading

marcosmarxm commented Nov 1, 2022

marcosmarxm commented Nov 2, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm Nov 8, 2022

Choose a reason for hiding this comment

jdpgrailsdev Nov 9, 2022

Choose a reason for hiding this comment

itaseskii Nov 9, 2022 • edited Loading

Choose a reason for hiding this comment

jdpgrailsdev Nov 10, 2022

Choose a reason for hiding this comment

itaseskii Nov 11, 2022

Choose a reason for hiding this comment

marcosmarxm commented Nov 8, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 8, 2022

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

RealChrisSean commented Nov 18, 2022

CLAassistant commented Nov 1, 2022 •

edited

Loading

itaseskii Nov 9, 2022 •

edited

Loading

marcosmarxm commented Nov 8, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading