-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/airbyte-cron] Cleanup env vars #18787
Merged
perangel
merged 3 commits into
master
from
perangel/fix/cleanup-airbyte-cron-helm-deployment-env-vars
Nov 1, 2022
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about airbyte_role, but for these two (remote_connector_catalog_url and update_definitions_cron_enabled), while they could be set on OSS, they're mainly meant for cloud usage so it's probably ok to remove for now if it's causing an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perangel is there a reason not to add them to the configmap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that
AIRBYTE_ROLE
is declared in https://github.com/airbytehq/airbyte/blob/master/airbyte-cron/src/main/resources/application.yml#L69. Anything not declared by the ConfigMap can still be provided viaenv_vars
orglobal.env_vars
so there's still a means to pass them through. But since these keys are definitely not in the ConfigMap, it should be safe to remove them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None that I am aware of, but I would like to get a second opinion since I see cases where other config keys that are declared in microaut apps are also not present in the ConfigMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for me, I've never seen those variables present in OSS deployments, only in cloud one, so if devs are ok with dropping those(meaning that it'll be safe), then we can drop them and test the deployment out.
For this you need to run the following: