Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Add DatePicker for date fields #18816

Closed
wants to merge 2 commits into from
Closed

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Nov 1, 2022

What

Closes #12197

Adding a new DatePicker component (based on react-datepicker) and use it in the ServiceForm for date and date-time fields.

How

The DatePicker component itself so far only works for dates in the UTC timezone. Since this is everything we currently working with in connectors, I decided to not overcomplicate the implementation of the component for now, and we can address time zones once we actually have the need for them.

TODOs

  • Design popover
  • Remove all debug output
  • Comment code
  • Storybook story
  • Unit tests (if applicable)

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 1, 2022
@timroes timroes changed the title 🪟 🎉 First implementation of DatePicker 🪟 🎉 Add DatePicker for date fields Nov 1, 2022
@timroes
Copy link
Collaborator Author

timroes commented Nov 28, 2022

Superseeded by #19678

@timroes timroes closed this Nov 28, 2022
@timroes timroes deleted the tim/datepicker branch February 9, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set date and/or time from a date picker in the connector UI
1 participant