Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Add links to demo page #18828

Merged
merged 1 commit into from
Nov 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@use "scss/colors";
@use "scss/variables";

.container {
display: flex;
Expand Down Expand Up @@ -42,3 +43,7 @@
left: 0;
}
}

.footer {
margin-top: variables.$spacing-xl;
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ interface EmptyResourceListViewProps {
buttonLabel: string;
resourceType: "connections" | "destinations" | "sources";
onCreateClick: () => void;
footer?: React.ReactNode;
}

export const EmptyResourceListView: React.FC<EmptyResourceListViewProps> = ({
resourceType,
onCreateClick,
buttonLabel,
footer,
}) => {
const { headingMessageId, singularResourceType } = useMemo(() => {
const singularResourceType = resourceType.substring(0, resourceType.length - 1);
Expand Down Expand Up @@ -50,6 +52,7 @@ export const EmptyResourceListView: React.FC<EmptyResourceListViewProps> = ({
<Button onClick={onCreateClick} size="lg" data-id={`new-${singularResourceType}`}>
{buttonLabel}
</Button>
{footer && <div className={styles.footer}>{footer}</div>}
</div>
);
};
4 changes: 3 additions & 1 deletion airbyte-webapp/src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@
"sidebar.resources": "Resources",
"sidebar.documentation": "Documentation",
"sidebar.joinSlack": "Join our Slack",
"sidebar.status": "Airbyte status",
"sidebar.status": "Airbyte Status",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording change, suggested by Natalie.

"sidebar.chat": "Chat with us",
"sidebar.support": "Support",
"sidebar.supportTicket": "Submit a Ticket",
"sidebar.recipes": "Tutorials - Use cases",
"sidebar.demo": "Explore our demo",

"form.continue": "Continue",
"form.error": "Error: {message}",
Expand Down Expand Up @@ -334,6 +335,7 @@
"syncMode.full_refresh": "Full refresh",
"syncMode.incremental": "Incremental",

"connection.emptyStateFooter": "or play around in our <demoLnk>demo instance</demoLnk>.",
"connection.resetModalTitle": "Stream configuration changed",
"connection.streamResetHint": "Due to changes in the stream configuration, we recommend a data reset. A reset will delete data in the destination of the affected streams and then re-sync that data. Skipping the reset is discouraged and might lead to unexpected behavior.",
"connection.streamFullResetHint": "Due to changes in the stream configuration, we recommend a data reset. A reset will delete data in the destination of the affected streams and then re-sync that data. Skipping the reset is discouraged and might lead to unexpected behavior.",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { faSlack } from "@fortawesome/free-brands-svg-icons";
import { faEnvelope } from "@fortawesome/free-regular-svg-icons";
import { faQuestionCircle } from "@fortawesome/free-solid-svg-icons";
import { faDesktop, faQuestionCircle } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import React from "react";
import { FormattedMessage, FormattedNumber } from "react-intl";
Expand All @@ -23,7 +23,6 @@ import ChatIcon from "views/layout/SideBar/components/ChatIcon";
import ConnectionsIcon from "views/layout/SideBar/components/ConnectionsIcon";
import DestinationIcon from "views/layout/SideBar/components/DestinationIcon";
import OnboardingIcon from "views/layout/SideBar/components/OnboardingIcon";
import RecipesIcon from "views/layout/SideBar/components/RecipesIcon";
import SettingsIcon from "views/layout/SideBar/components/SettingsIcon";
import { SidebarDropdownMenu, SidebarDropdownMenuItemType } from "views/layout/SideBar/components/SidebarDropdownMenu";
import SourceIcon from "views/layout/SideBar/components/SourceIcon";
Expand Down Expand Up @@ -129,9 +128,9 @@ const SideBar: React.FC = () => {
},
{
type: SidebarDropdownMenuItemType.LINK,
href: links.tutorialLink,
icon: <RecipesIcon />,
displayName: <FormattedMessage id="sidebar.recipes" />,
href: links.demoLink,
icon: <FontAwesomeIcon icon={faDesktop} />,
displayName: <FormattedMessage id="sidebar.demo" />,
},
]}
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@use "scss/colors";

.link {
color: colors.$dark-blue;

&:hover,
&:focus {
color: colors.$blue-400;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ import { PageHeader } from "components/ui/PageHeader";

import { useTrackPage, PageTrackingCodes } from "hooks/services/Analytics";
import { useConnectionList } from "hooks/services/useConnectionHook";
import { links } from "utils/links";

import { RoutePaths } from "../../../routePaths";
import styles from "./AllConnectionsPage.module.scss";
import ConnectionsTable from "./components/ConnectionsTable";

const AllConnectionsPage: React.FC = () => {
Expand Down Expand Up @@ -48,6 +50,18 @@ const AllConnectionsPage: React.FC = () => {
resourceType="connections"
onCreateClick={onCreateClick}
buttonLabel={formatMessage({ id: "connection.createFirst" })}
footer={
<FormattedMessage
id="connection.emptyStateFooter"
values={{
demoLnk: (children: React.ReactNode) => (
<a href={links.demoLink} target="_blank" rel="noreferrer noopener" className={styles.link}>
{children}
</a>
),
}}
/>
}
/>
)}
</Suspense>
Expand Down