-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Pexels API [low-code cdk] #18854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @btkcodedev, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.
Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:
- Make sure you have added connector documentation to
/docs/integrations/
- Remove the file
catalog
from/integration_tests
- Edit the
sample_config.json
inside/integration_tests
- For the
configured_catalog
you can use onlyjson_schema: {}
- Add title to all properties in the
spec.yaml
- Make sure the
documentationUrl
in thespec.yaml
redirect to Airbyte's future connector page, eg: connector Airtable thedocumentationUrl: https://docs.airbyte.com/integrations/sources/airtable
- Review now new line at EOF (end-of-file) for all files.
If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.
Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in Sorry the inconvenience and see you again next week, thank you so much for your contribution! |
All comments resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, there are some points need imprvements.
airbyte-integrations/connectors/source-pexels-api/source_pexels_api/spec.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-pexels-api/source_pexels_api/pexels_api.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-pexels-api/source_pexels_api/pexels_api.yaml
Outdated
Show resolved
Hide resolved
@marcosmarxm All comments resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
airbyte-integrations/connectors/source-pexels-api/source_pexels_api/pexels_api.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-pexels-api/source_pexels_api/pexels_api.yaml
Outdated
Show resolved
Hide resolved
@marcosmarxm All comments resolved |
@btkcodedev I'll review your PR today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, I'm having problem running tests with current configuration.
- photo_id | ||
- video_id | ||
- collection_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btkcodedev I think this still not right. I don't want to retrieve only one photo and a video and a collection. I want to probably pass a collection id and retrieve all data inside of it.
I think most valuable for this connector it is to only implement the endpoint for search or retrieve data from collections id.
Because this contribution didn't receive recent updates it won't be consider valid to hacktoberfest event. You can continue the work to get this merge in your own pace. Thank so much for your contribution! |
um..I've just made the final change just right now. It's ready for shipping |
I'll test your changes later. |
Thanks! pal. Really appreciating your maintainership |
/test connector=connectors/source-pexels-api
Build FailedTest summary info:
|
/test connector=connectors/source-pexels-api
Build PassedTest summary info:
|
/publish connector=connectors/source-pexels-api
if you have connectors that successfully published but failed definition generation, follow step 4 here |
well well, @RealChrisSean base branch is locked because of code freeze. I can't merge this PR but it was published before the deadline! Thanks for the contribution @btkcodedev |
Hello 👋, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
@marcosmarxm Could I get that hacktober label back and merge this PR :) |
What
Developing new connector for the source: Pexels API
New data source will be definitely useful for image data url's
Resolves:
🎉 New Source: Pexels API
How
Developed using low-code cdk
Recommended reading order
spec.yaml
pexels-api.yaml
schemas/*
🚨 User Impact 🚨
New Connector: Source Pexels API
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Tests
Integration & Acceptance
Full Test Results