🪟 🔧 Add Segment event to invite users modal #18862
Conversation
github-actions
bot
added
area/platform
| @@ -19,7 +19,9 @@ export const useInviteUsersModalService = () => { | |||
| return ctx; | |||
| }; | |||
|
|
|||
| export const InviteUsersModalServiceProvider: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => { | |||
| export const InviteUsersModalServiceProvider: React.FC< | |||
| React.PropsWithChildren<unknown> & { invitedFrom: "source" | "destination" | "user.settings" } | |||
There was a problem hiding this comment.
We try to always exclude properties into their own interface, i.e. as a InviteUsersModalServiceProviderProps. Also that interface, should be used as the generic type for PropsWithChildren instead of intersected with it, i.e. React.FC<React.PropsWithChildren<InviteUsersModalServiceProviderProps>>
There was a problem hiding this comment.
I'll make the change 😊
Could you explain why we prefer to/should use the interface as the generic type?
I'm super interested in learning more about Typescript as I'm fairly new to it and don't usually use more than basics.
There was a problem hiding this comment.
The React.PropsWithChildren's sole purpose is basically to wrap the properties and add children to those props, so doing React.PropsWithChildren<unknown> & { ... } is kind of like saying: I have the perfect template for a shopping list at home, and when going to the shop I take that (empty) template and my actual list ("Manolitos, Manolitos, and more Manolitos") that I wrote on a completely blank second paper. (I'll let you know once I come up with a better analogy.)
There was a problem hiding this comment.
Great analogy! Totally understood! thanks for taking the time to explain it 😊
letiescanciano
force-pushed
the
analytics/add-tracking-to-invite-users-experiment
branch
from
909fdc0 to
1af5dbd
Compare
letiescanciano
deleted the
analytics/add-tracking-to-invite-users-experiment
branch
Demo: https://www.loom.com/share/1e899c9678124321a62dc71d23bfe52e
What
Adding a new
Airbyte.UI.User.InviteSegment event to be able to track user invites across sources, destinations and access management pages.How
Add new event
Add tracking on invite