Embed Metabase Connector Catalog #18864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces static connector catalog with the embedded Metabase connector catalog
github-actions
bot
added
the
area/documentation
supertopher
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks @TBernstein4 @ajmhatch and @Amruta-Ranade !!
this looks great! I'm really excited about this change!
tybernstein
added a commit
that referenced
this pull request
Nov 7, 2022
This reverts commit 022fca8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces static connector catalog with the embedded Metabase connector catalog.
Tested locally and it ran successfully. See below:
